Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716398 - sys-devel/prelink should not depend on dev-libs/elfutils and sys-libs/libselinux with [static-libs(+)]
Summary: sys-devel/prelink should not depend on dev-libs/elfutils and sys-libs/libseli...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-05 23:53 UTC by Alexander Miller
Modified: 2020-04-06 20:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (prelink.patch,3.76 KB, patch)
2020-04-06 01:20 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Miller 2020-04-05 23:53:31 UTC
Both sys-devel/prelink-20151030 and sys-devel/prelink-99999999 list in their dependencies:
 * >=dev-libs/elfutils-0.100[static-libs(+)]
 * selinux? ( sys-libs/libselinux[static-libs(+)] )

However, the build system doesn't use the static libs. It simply links with -lelf in case of elfutils (not tested with selinux, but I can't see anything related to static libs either). When I remove the "[static-libs(+)]" part and build elfutils
with USE=-static-libs, prelink still builds without problems.

The static-libs USE dependencies should be dropped.
Comment 1 Arfrever Frehtes Taifersar Arahesis 2020-04-06 00:41:34 UTC
-all-static option was dropped in:

https://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/commit/?id=e2aedb732189092bb4f5b3a128c52ff4e92429b7

commit e2aedb732189092bb4f5b3a128c52ff4e92429b7
Author:     Mark Hatle <mark.hatle@windriver.com>
AuthorDate: 2010-06-14 16:35:10 -0500
Commit:     Mark Hatle <mark.hatle@windriver.com>
CommitDate: 2010-07-22 17:44:56 -0500

    Add switch to disable selinux when linking
    
    Add --disable-selinux.  Also remove static linking as many modern
    components do not support static linking.

--- trunk/src/Makefile.am
+++ trunk/src/Makefile.am
...
-prelink_LDFLAGS = -all-static
+prelink_LDFLAGS =
...
-prelink_rtld_LDFLAGS = -all-static
+prelink_rtld_LDFLAGS =
Comment 2 Arfrever Frehtes Taifersar Arahesis 2020-04-06 00:52:18 UTC
By the way, sys-libs/binutils-libs is in DEPEND and RDEPEND, but it seems that the only usage in build system is:
src/Makefile.am:prelink_LDADD = @LIBGELF@ -liberty
src/Makefile.am:execstack_LDADD = -liberty

sys-libs/binutils-libs provides only libiberty.a static library, no libiberty.so, so maybe sys-libs/binutils-libs should be dropped from RDEPEND.

(Dependencies on >=sys-libs/glibc-2.8 and >=sys-devel/binutils-2.18 can be also dropped.)
Comment 3 Arfrever Frehtes Taifersar Arahesis 2020-04-06 01:20:43 UTC
Created attachment 630614 [details, diff]
Patch
Comment 4 Larry the Git Cow gentoo-dev 2020-04-06 20:30:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9c1d515f96df7d2893dcea146b30a2b4baef0265

commit 9c1d515f96df7d2893dcea146b30a2b4baef0265
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2020-04-06 01:06:13 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-04-06 20:30:39 +0000

    sys-devel/prelink: Update dependencies.
    
    Closes: https://bugs.gentoo.org/716398
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-devel/prelink/prelink-20151030.ebuild | 14 ++++++--------
 sys-devel/prelink/prelink-99999999.ebuild | 14 ++++++--------
 2 files changed, 12 insertions(+), 16 deletions(-)
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2020-04-06 20:31:15 UTC
Pulled as is. Thanks all!