Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716394 - media-gfx/displaycal should depend on dev-python/dbus-python
Summary: media-gfx/displaycal should depend on dev-python/dbus-python
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-05 22:04 UTC by Maciej S. Szmigiero
Modified: 2020-04-10 08:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej S. Szmigiero 2020-04-05 22:04:56 UTC
media-gfx/displaycal should (runtime) depend on dev-python/dbus-python, since without this package installed it does not start:
ImportError: No module named dbus
Exiting displaycal
Comment 1 Bernard Cafarelli gentoo-dev 2020-04-09 19:11:27 UTC
Thanks for the report, this was also reported in Debian and upstream:
https://hub.displaycal.net/issue/20470/

I cannot test displaycal for now as the package is still python2 only with no visible progress on python3 support, can you test and confirm it works properly with pygobject? As dbus-python is deprecated and only intended as fallback

If all good I will push revision bump with some added rdep looking like:
	|| (
		dev-python/pygobject[${PYTHON_USEDEP}]
		dev-python/dbus-python[${PYTHON_USEDEP}]
	)
Comment 2 Maciej S. Szmigiero 2020-04-09 19:54:40 UTC
Thanks for working at this bug.

I can confirm that the package starts correctly when dev-python/pygobject:3 is installed instead of dev-python/dbus-python.
Comment 3 Maciej S. Szmigiero 2020-04-09 19:55:23 UTC
"the package starts correctly" - I mean that displaycal starts correctly.
Comment 4 Bernard Cafarelli gentoo-dev 2020-04-10 08:26:58 UTC
Thanks for the fast confirmation! Adding as 3.8.9.3-r1
Comment 5 Larry the Git Cow gentoo-dev 2020-04-10 08:32:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc9be892be616a24a751f7731d0155d8b730ab53

commit dc9be892be616a24a751f7731d0155d8b730ab53
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2020-04-10 08:31:13 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2020-04-10 08:31:59 +0000

    media-gfx/displaycal: add missing dbus rdep
    
    Thanks Maciej S. Szmigiero for report and testing
    
    Closes: https://bugs.gentoo.org/716394
    Package-Manager: Portage-2.3.98, Repoman-2.3.22
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 .../{displaycal-3.8.9.3.ebuild => displaycal-3.8.9.3-r1.ebuild}       | 4 ++++
 1 file changed, 4 insertions(+)