Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716254 - dev-libs/jsoncpp-1.9.2-r2: test failure (EscapeSequenceTest/writeEscapeSequence)
Summary: dev-libs/jsoncpp-1.9.2-r2: test failure (EscapeSequenceTest/writeEscapeSequence)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 710594
  Show dependency tree
 
Reported: 2020-04-05 09:04 UTC by Alexey
Modified: 2020-04-13 12:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,22.22 KB, text/x-log)
2020-04-05 09:04 UTC, Alexey
Details
testlog.txt (testlog.txt,76.30 KB, text/plain)
2020-04-05 09:04 UTC, Alexey
Details
emerge --info (file_716254.txt,15.06 KB, text/plain)
2020-04-05 09:04 UTC, Alexey
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey 2020-04-05 09:04:07 UTC
Created attachment 630156 [details]
build.log

* Detail of EscapeSequenceTest/writeEscapeSequence test failure:
../jsoncpp-1.9.2/src/test_lib_json/main.cpp(3370): expected == result
  Expected: '["\"","\\","\b","\f","\n","\r","\t","\u0278","\ud852\udf62"]
  '
  Actual  : '["\"","\\","\b","\f","\n","\r","\t","ɸ","𤭢"]

Exceeded stackLimit in readValue().
Failed to parse input file:
* Line 1, Column 5
  Missing ',' or ']' in array declaration
Comment 1 Alexey 2020-04-05 09:04:26 UTC
Created attachment 630158 [details]
testlog.txt
Comment 2 Alexey 2020-04-05 09:04:55 UTC
Created attachment 630160 [details]
emerge --info
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-06 06:11:39 UTC
I can't reproduce this.  At first I thought it's locale-related but it seems that the tests are run with en_US.utf8, and I can't reproduce it with that either.  To be honest, I don't see code that could be affected by arch either.

Can you reproduce on another system?  Any suggestion what could be affecting it?
Comment 4 Alexey 2020-04-06 08:40:49 UTC
https://github.com/open-source-parsers/jsoncpp/pull/1120 fixes it; on arm arch, char is unsigned when not specified.

Is "Exceeded stackLimit in readValue()" expected and only writeEscapeSequence has actual failure?
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-06 08:57:06 UTC
Oh nice.  I haven't looked at the other problem yet.  Could you try testing upstream's git to see the current status?  I can make a snapshot later.
Comment 6 Alexey 2020-04-06 10:18:41 UTC
I've applied the patch to 1.9.2-r2, and the test passes now.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-06 10:22:27 UTC
I was hoping you'd check whether the stack problem is resolved in git HEAD too.
Comment 8 Alexey 2020-04-06 11:04:00 UTC
I meant, the whole test suite passed, and the package got merged to my system. The stack message is still in the test log, but it looks like that's not a failure.
Comment 9 Alexey 2020-04-06 11:12:46 UTC
Re git HEAD: since there's no 9999 version in portage, that's hard for me to do. And I feel too lazy now adding the 9999 ebuild.
Comment 10 Larry the Git Cow gentoo-dev 2020-04-13 12:07:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b411be38a6e8a69a290ffd2551e1e502dae78a54

commit b411be38a6e8a69a290ffd2551e1e502dae78a54
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-04-13 11:38:06 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-04-13 12:07:29 +0000

    dev-libs/jsoncpp: Bump to 1.9.3_pre20200412 snapshot
    
    Closes: https://bugs.gentoo.org/716254
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-libs/jsoncpp/Manifest                         |  1 +
 dev-libs/jsoncpp/jsoncpp-1.9.3_pre20200412.ebuild | 47 +++++++++++++++++++++++
 2 files changed, 48 insertions(+)