Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 715998 - www-client/firefox-bin-74.0-r2: newins: .../default16.png does not exist
Summary: www-client/firefox-bin-74.0-r2: newins: .../default16.png does not exist
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-03 07:32 UTC by Joonas Niilola
Modified: 2020-04-03 09:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2020-04-03 07:32:01 UTC
This bug is super weird. Any *new* installation of firefox-bin fails to this error message: 

  >>> Install www-client/firefox-bin-74.0-r2 into /tmp/portage/www-client/firefox-bin-74.0-r2/image/
 * ERROR: www-client/firefox-bin-74.0-r2::gentoo failed (install phase):
 *   !!! newins: /opt/firefox/browser/chrome/icons/default/default16.png does not exist

But if I install 74.0 or 74.0-r1 from git history, and THEN update, it will succeed. 

I bisected and ever since https://gitweb.gentoo.org/repo/gentoo.git/diff/www-client/firefox-bin/firefox-bin-74.0-r1.ebuild?id=ad207c941c2cebd1b5051ac7ad00e511ecdd7ef0 this commit, firefox-bin fails. This also happens with 68.6.0-r2 but I noticed it received similar modifications.

What's also confusing is that if I change 

  newins "${icon_path}/default${size}.png" "${icon}.png"

to

  newins "${ED}/${icon_path}/default${size}.png" "${icon}.png"

it fails for a different reason, but nevertheless fails.

Does it try to search for those icons in live root system, instead of DESTDIR?
Comment 1 Larry the Git Cow gentoo-dev 2020-04-03 09:55:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf2a999fb1d4c1d4d1749aeda04ae4e1aa023924

commit cf2a999fb1d4c1d4d1749aeda04ae4e1aa023924
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-04-03 09:45:20 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-04-03 09:55:17 +0000

    www-client/firefox-bin: install files from $D
    
    Commit f49167d933ef33c4f02f0aa335bb91f251ba1e7f re-ordered install order.
    
    Because we now move $S/firefox to $D at the beginning of src_install,
    we must point to $D when installing these files.
    
    Closes: https://bugs.gentoo.org/715998
    Package-Manager: Portage-2.3.96, Repoman-2.3.22
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox-bin/firefox-bin-68.6.0-r2.ebuild | 4 ++--
 www-client/firefox-bin/firefox-bin-74.0-r2.ebuild   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)