Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 715790 - sys-fs/squashfs-tools-ng-0.9 needs to include assert.h
Summary: sys-fs/squashfs-tools-ng-0.9 needs to include assert.h
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matt Turner
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-01 18:21 UTC by Helmut Jarausch
Modified: 2020-04-04 03:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2020-04-01 18:21:37 UTC
The files lib/common/compress.c and lib/sqfs/comp/lz4/lz4hc.h
use the assert macro without including assert.h
This gives a linker error because it cannot find the function 'assert'

The following sed command included in src_prepare of the ebuild fixes this:

sed -i -e'/#include/a \
#include <assert.h>' lib/common/compress.c lib/sqfs/comp/lz4/lz4hc.h
Comment 1 Larry the Git Cow gentoo-dev 2020-04-04 03:15:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ddfed3ec49867b804baa6af98220ec437e8d117a

commit ddfed3ec49867b804baa6af98220ec437e8d117a
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2020-04-04 03:13:52 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-04-04 03:14:55 +0000

    sys-fs/squashfs-tools-ng: Fix build failure
    
    Closes: https://bugs.gentoo.org/715790
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 ...ols-ng-0.9-Fix-missing-header-without-LZO.patch | 32 ++++++++++++++++++++++
 .../squashfs-tools-ng/squashfs-tools-ng-0.9.ebuild |  4 +++
 2 files changed, 36 insertions(+)
Comment 2 Matt Turner gentoo-dev 2020-04-04 03:16:01 UTC
I poked around and couldn't trigger a failure due to a missing header in lz4hc.h. If you know how, please file an issue upstream at https://github.com/AgentD/squashfs-tools-ng/issues