Created attachment 627520 [details] build.log Rebuilding bbswitch after upgrading to gentoo-sources 5.6.0 fails with CC [M] /var/tmp/portage/sys-power/bbswitch-0.8-r2/work/bbswitch-0.8/bbswitch.o /var/tmp/portage/sys-power/bbswitch-0.8-r2/work/bbswitch-0.8/bbswitch.c: In function ‘bbswitch_init’: /var/tmp/portage/sys-power/bbswitch-0.8-r2/work/bbswitch-0.8/bbswitch.c:467:63: error: passing argument 4 of ‘proc_create’ from incompatible pointer type [-Werror=incompatible-pointer-types] 467 | acpi_entry = proc_create("bbswitch", 0664, acpi_root_dir, &bbswitch_fops); | ^~~~~~~~~~~~~~ | | | struct file_operations * In file included from ./include/acpi/acpi_bus.h:83, from ./include/linux/acpi.h:32, from /var/tmp/portage/sys-power/bbswitch-0.8-r2/work/bbswitch-0.8/bbswitch.c:32: ./include/linux/proc_fs.h:64:24: note: expected ‘const struct proc_ops *’ but argument is of type ‘struct file_operations *’ 64 | struct proc_dir_entry *proc_create(const char *name, umode_t mode, struct proc_dir_entry *parent, const struct proc_ops *proc_ops); | ^~~~~~~~~~~ cc1: some warnings being treated as errors
Created attachment 627662 [details, diff] bbswitch-0.8-r2-kernel-5.6.patch This patch seems to have fixed it for me
Hello there, Is this patch your of have you fetched it from somewhere? It has no patch-format notes at the top. In any case, would you kindly submit it upstream and link the pull request / issue for reference?
Created attachment 627942 [details, diff] bbswitch-0.8-r2-kernel-5.6.patch The patch is mine, here's a better one, made with git format-patch. It's applied on top of a commit with the patch we already use https://github.com/gentoo/gentoo/blob/master/sys-power/bbswitch/files/bbswitch-0.8-kernel-4.12.patch I don't know if that's the correct way to submit, but that's how I had to do it in my /etc/portage/patches for it to work without merge conflicts. Here's a PR with a version of the patch for upstream, but they haven't done a release since 2013, so we'll probably need to include a patch on our own. https://github.com/Bumblebee-Project/bbswitch/pull/196
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b8a4109655d335052fff129b206061ecb5ad845a commit b8a4109655d335052fff129b206061ecb5ad845a Author: Piotr Karbowski <slashbeast@gentoo.org> AuthorDate: 2020-04-06 18:40:41 +0000 Commit: Piotr Karbowski <slashbeast@gentoo.org> CommitDate: 2020-04-06 18:42:10 +0000 sys-power/bbswitch-0.8-r3: kernel 5.6 support; $CC fixes. Closes: https://bugs.gentoo.org/715500 Closes: https://bugs.gentoo.org/702730 Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org> sys-power/bbswitch/bbswitch-0.8-r3.ebuild | 57 ++++++++++++++++++++++ sys-power/bbswitch/bbswitch-9999.ebuild | 11 +++-- .../bbswitch/files/bbswitch-0.8-kernel-5.6.patch | 52 ++++++++++++++++++++ 3 files changed, 116 insertions(+), 4 deletions(-)
Seems like upstream is MIA. Commited your patch, thanks.
