Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 715184 - www-client/luakit-9999 - fails to find modules after install because of missing prefix in compile phase (PATCH)
Summary: www-client/luakit-9999 - fails to find modules after install because of missi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2020-03-28 17:48 UTC by Kris
Modified: 2020-04-01 14:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch from my local ebuild to fix the issues in the description (luakit-9999.patch,1.12 KB, patch)
2020-03-28 17:48 UTC, Kris
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kris 2020-03-28 17:48:39 UTC
Created attachment 626564 [details, diff]
patch from my local ebuild to fix the issues in the description

luakit fails to load modules. This is not a upstream bug, PREFIX needs to be added to the make command during compile phase because its added to the make command during install phase. 

Emerge also warns that using git-r3 is insecure and to use htttps, also missing xdg_* functions for the desktop file.
Comment 1 Kris 2020-03-28 17:53:37 UTC
Emerge complains about installing compressed man pages when auto compression is enabled, added a fix to the patch. Not sure if there is a better way to fix that or not.
Comment 2 Jonas Stein gentoo-dev 2020-03-28 19:10:12 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck
* We always try to use the latest EAPI, please bump to EAPI=7
* A bot can look for additional mistakes, if you upload a PR via github
* sed -i 's/install -m644 luakit.1.gz/install -m644 luakit.1/g' Makefile
  needs || die

Add 
Closes: https://bugs.gentoo.org/715184
in the comment of the PR
Comment 3 Larry the Git Cow gentoo-dev 2020-04-01 14:37:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8d672db8ff6df16fc571bb725fceb3d37ad69b0

commit e8d672db8ff6df16fc571bb725fceb3d37ad69b0
Author:     Kristopher Keller <kristopher004@gmail.com>
AuthorDate: 2020-03-28 22:26:23 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-04-01 14:37:33 +0000

    www-client/luakit: update live ebuild
    
    Add prefix to emake so luakit can find modules and fix various repoman
    warnings.
    
      - Bump copyright
      - Bump to EAPI 7
      - Inherit xdg-utils
      - Use https for repo uri
      - Add PREFIX to emake in compile phase
      - Edit Makefile to install uncompressed man page
      - Add xdg functions for desktop file
    
    Closes: https://bugs.gentoo.org/715184
    Package-Manager: Portage-2.3.96, Repoman-2.3.22
    Signed-off-by: Kristopher Keller <kristopher004@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/15157
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/luakit/luakit-9999.ebuild | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)