Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 715148 - dev-python/spyder: forces downgrade of dev-python/parso
Summary: dev-python/spyder: forces downgrade of dev-python/parso
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrey Grozin
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-03-28 11:26 UTC by Michał Górny
Modified: 2020-04-11 20:00 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-28 11:26:27 UTC
NonsolvableDepsInStable: version 4.1.1: nonsolvable depset(rdepend) keyword(~amd64) stable profile (default/linux/amd64/17.0) (39 total): solutions: [ ~dev-python/parso-0.5.2[-python_single_target_python3_6(-),-python_single_target_python3_7(-),python_targets_python3_6(-),python_targets_python3_7(-)] ]
Comment 1 Andrew Ammerlaan gentoo-dev 2020-03-28 11:29:30 UTC
spyder-4.1.1 requires =parso-0.5.2: https://github.com/spyder-ide/spyder/blob/master/setup.py

What exactly is the problem, version 0.5.2 is available is it not?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-28 11:37:24 UTC
It is available only because this version happened to be committed few minutes before I tried to remove it.  The problem is that you're preventing users from using a newer version.

Does it really require this version of parso, or is it just upstream being overly strict?  If yes, then can you patch it to work with *at least* the current stable?
Comment 3 Andrew Ammerlaan gentoo-dev 2020-03-28 11:43:52 UTC
> Does it really require this version of parso, or is it just upstream being overly strict?  If yes, then can you patch it to work with *at least* the current stable?

spyder gives a very annoying pop up every time you start it if you do not have the correct dependencies. Regardless of whether spyder will work or not with newer parso versions, you will get this pop up. There already is an issue open on the bugtrakcer about this: https://github.com/spyder-ide/spyder/issues/11975

Apparently they do not plan on changing this till 4.2.0

So it's either having an outdated ebuild of parso lying around, or having all spyder users deal with the (very abnnoying) pop up. At least until spyder-4.2.0, sorry about that :(
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-28 11:46:44 UTC
Patch it out.
Comment 5 Larry the Git Cow gentoo-dev 2020-03-28 14:21:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca92233cb00fbd9bbc8962516d8f774906b4f12e

commit ca92233cb00fbd9bbc8962516d8f774906b4f12e
Author:     Andrew Ammerlaan <andrewammerlaan@riseup.net>
AuthorDate: 2020-03-28 13:48:33 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-03-28 14:21:18 +0000

    dev-python/spyder: allow newer parso versions
    
    Closes: https://bugs.gentoo.org/715148
    Package-Manager: Portage-2.3.96, Repoman-2.3.22
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@riseup.net>
    Closes: https://github.com/gentoo/gentoo/pull/15149
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../files/spyder-4.1.1-allow-newer-parso.patch     | 39 ++++++++++++++++++++++
 dev-python/spyder/spyder-4.1.1.ebuild              |  9 +++--
 2 files changed, 45 insertions(+), 3 deletions(-)
Comment 6 Erik Quaeghebeur 2020-03-29 19:32:31 UTC
The patch doesn't apply here:

 * Applying spyder-4.1.1-allow-newer-parso.patch ...
patching file requirements/conda.txt                                               
patching file setup.py                                                             
Hunk #1 succeeded at 188 (offset -30 lines).                     
patching file spyder/dependencies.py                                                                                                                                   
Hunk #1 FAILED at 41 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file spyder/dependencies.py.rej
 [ !! ]
Comment 7 Andrew Ammerlaan gentoo-dev 2020-03-30 07:45:49 UTC
> The patch doesn't apply here:

The file I'm trying to patch here has DOS style End-Of-Line for some reason. I had the patch working with this, but it seems that somewhere between making the patch and downloading it again from the repo after committing the EOL of the patch has been converted to UNIX so it's no longer working. I'll look into an alternative solution, probably using sed instead.
Comment 8 Joonas Niilola gentoo-dev 2020-03-30 11:19:26 UTC
Hmm, I wonder how exactly that happened. Patch from Github works, patch in ::gentoo doesn't.

Was it my desktop's locale thing, or something in gitweb.gentoo.org? How can we prevent this from happening again? Mgorny, ideas?
Comment 9 Larry the Git Cow gentoo-dev 2020-03-30 11:27:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d9a2d6cf1469a9bf1aec1c75fd54fe8b121883c6

commit d9a2d6cf1469a9bf1aec1c75fd54fe8b121883c6
Author:     Andrew Ammerlaan <andrewammerlaan@riseup.net>
AuthorDate: 2020-03-30 08:33:38 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-03-30 11:26:38 +0000

    dev-python/spyder: use sed instead of patch
    
    trying to patch file with DOS EOL
    the patch got converted to UNIX EOL
    somehwere along the road and is not working
    
    Bug: https://bugs.gentoo.org/715148
    
    Package-Manager: Portage-2.3.96, Repoman-2.3.22
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@riseup.net>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-python/spyder/spyder-4.1.1-r2.ebuild | 163 +++++++++++++++++++++++++++++++
 1 file changed, 163 insertions(+)
Comment 10 Andrew Ammerlaan gentoo-dev 2020-04-11 20:00:03 UTC
spyder-4.1.2. tests segfault with parso>0.5.2, so I'm afraid the 4.1.2 ebuild will have to depend on the 0.5.2 version.