Bug 714906 – Stages should default to LANG="C.utf8"

• Status: RESOLVED FIXED
• Product: Gentoo Release Media

[Description Matt Turner 2020-03-26 18:31:54 UTC]

dilfridge says that many packages require a unicode-capable locale and suggests that we include an /etc/env.d/02locale that contains "LANG=C.utf8"

[Comment 1 Larry the Git Cow 2020-04-08 00:25:14 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=f0e772bd3905d02d691d0e41b3a8e3bd3c10e2fe

commit f0e772bd3905d02d691d0e41b3a8e3bd3c10e2fe
Author:     Matt Turner <[e-mail]>
AuthorDate: 2020-03-27 23:28:11 +0000
Commit:     Matt Turner <[e-mail]>
CommitDate: 2020-04-07 23:23:07 +0000

    targets: Set LANG=C.UTF8
    
    Stable glibc now always provides a UTF-8 capable locale, which many
    packages require. Set this as the default LANG.
    
    Running locale-gen in stage1 should also solve bug #536938.
    
    Bug: https://bugs.gentoo.org/536938
    Bug: https://bugs.gentoo.org/710762
    Bug: https://bugs.gentoo.org/714906
    Signed-off-by: Matt Turner <[e-mail]>

 targets/stage1/chroot.sh | 12 ++++++++++++
 1 file changed, 12 insertions(+)

[Comment 2 Anthony Basile 2020-05-06 20:10:14 UTC]

(In reply to Larry the Git Cow from comment #1)
> The bug has been referenced in the following commit(s):
> 
> https://gitweb.gentoo.org/proj/catalyst.git/commit/
> ?id=f0e772bd3905d02d691d0e41b3a8e3bd3c10e2fe
> 
> commit f0e772bd3905d02d691d0e41b3a8e3bd3c10e2fe
> Author:     Matt Turner <[e-mail]>
> AuthorDate: 2020-03-27 23:28:11 +0000
> Commit:     Matt Turner <[e-mail]>
> CommitDate: 2020-04-07 23:23:07 +0000
> 
>     targets: Set LANG=C.UTF8
>     
>     Stable glibc now always provides a UTF-8 capable locale, which many
>     packages require. Set this as the default LANG.
>     
>     Running locale-gen in stage1 should also solve bug #536938.
>     
>     Bug: https://bugs.gentoo.org/536938
>     Bug: https://bugs.gentoo.org/710762
>     Bug: https://bugs.gentoo.org/714906
>     Signed-off-by: Matt Turner <[e-mail]>
> 
>  targets/stage1/chroot.sh | 12 ++++++++++++
>  1 file changed, 12 insertions(+)


This will probably break musl and uclibc builds.

[Comment 3 Anthony Basile 2020-05-06 20:14:25 UTC]

> This will probably break musl and uclibc builds.

Let me update that, it definitely will break musl and uclibc build because there is no locale-gen.  Can you shield this with a `if type ... ` please.

Also can you test these things on musl/uclibc systems as well as glibc.

[Comment 4 Matt Turner 2020-05-06 20:28:22 UTC]

(In reply to Anthony Basile from comment #3)
> > This will probably break musl and uclibc builds.
> 
> Let me update that, it definitely will break musl and uclibc build because
> there is no locale-gen.  Can you shield this with a `if type ... ` please.
> 
> Also can you test these things on musl/uclibc systems as well as glibc.

Thanks.

Is there any equivalent on musl/uclibc or should we just skip doing all of this on those profiles?

[Comment 5 Anthony Basile 2020-05-06 21:14:15 UTC]

(In reply to Matt Turner from comment #4)
> (In reply to Anthony Basile from comment #3)
> > > This will probably break musl and uclibc builds.
> > 
> > Let me update that, it definitely will break musl and uclibc build because
> > there is no locale-gen.  Can you shield this with a `if type ... ` please.
> > 
> > Also can you test these things on musl/uclibc systems as well as glibc.
> 
> Thanks.
> 
> Is there any equivalent on musl/uclibc or should we just skip doing all of
> this on those profiles?

Let's skip it for now.  locales are problematic on both.

[Comment 6 Matt Turner 2020-05-20 18:04:22 UTC]

This is included in catalyst-3.0.10.