Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 714096 - www-apps/novnc-1.0.0: Patch to create a symlink in /usr/bin
Summary: www-apps/novnc-1.0.0: Patch to create a symlink in /usr/bin
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-03-23 18:49 UTC by El Acheche Anis
Modified: 2020-03-24 17:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
novnc-1.0.0.ebuild (novnc-1.0.0.ebuild,1.06 KB, text/plain)
2020-03-23 18:50 UTC, El Acheche Anis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description El Acheche Anis 2020-03-23 18:49:13 UTC
The ebuild don't create a symlink to the launch.sh script in $PATH

Please find attached novnc-1.0.0.ebuild that create a symlink of "/usr/share/novnc/utils/launch.sh" in "/usr/bin"

Reproducible: Always

Steps to Reproduce:
1. Install the ebuild
Actual Results:  
Need to execute "/usr/share/novnc/utils/launch.sh" instead of executing a command from $PATH

Expected Results:  
Being able to start "novnc" from cli/$PATH
Comment 1 El Acheche Anis 2020-03-23 18:50:37 UTC
Created attachment 624750 [details]
novnc-1.0.0.ebuild
Comment 2 Jonas Stein gentoo-dev 2020-03-23 19:08:15 UTC
While touching the file I suggest to bump to EAPI=7

Is there a reason for echo in

python_compile() {
	echo
}

Else I suggest to six it with a NOP

python_compile() {
	:
}
Comment 3 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2020-03-24 02:15:25 UTC
I think the echo was a to noop out of the default, fixed.

I'm not sure what the PTYTHON_COMPAT is good for, I guess just to ensure the deps are installed.

I'm not sure I think including a generic script name like launch.sh is a good idea.  novnc is generally called directly by other apps (like nova) (at least in my usage).

gonna close as won't fix based on its targeted use
Comment 4 El Acheche Anis 2020-03-24 09:30:54 UTC
It can be used as a standalone VNC client as well.. 

In that case, installing it then looking for a novnc binary and reading the install docs from the official website and other websites to found out about the launch.sh file is a waste of time :)
Comment 5 Larry the Git Cow gentoo-dev 2020-03-24 17:11:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d3ef689b07ac07ce057fa958a5a429b98b3e92bb

commit d3ef689b07ac07ce057fa958a5a429b98b3e92bb
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2020-03-24 17:10:46 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2020-03-24 17:11:26 +0000

    www-apps/novnc: fix install and create /usr/bin symlink
    
    Closes: https://bugs.gentoo.org/714096
    Closes: https://bugs.gentoo.org/714202
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 www-apps/novnc/novnc-1.1.0.ebuild | 2 ++
 www-apps/novnc/novnc-9999.ebuild  | 2 ++
 2 files changed, 4 insertions(+)