Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 713878 - media-sound/pulseaudio-modules-bt Update pulseaudio-modules-bt with use flags
Summary: media-sound/pulseaudio-modules-bt Update pulseaudio-modules-bt with use flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Jason A. Donenfeld
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2020-03-22 01:35 UTC by Pablo Cholaky
Modified: 2020-04-01 05:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pulseaudio-modules-bt-1.3-r1 proposal (pulseaudio-modules-bt-1.3-r1.ebuild,1.82 KB, text/plain)
2020-03-22 01:36 UTC, Pablo Cholaky
Details
Proposal metadata.xml (metadata.xml,368 bytes, text/xml)
2020-03-22 01:36 UTC, Pablo Cholaky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Cholaky 2020-03-22 01:35:20 UTC
Hi maintainer,

pulseaudio-modules-bt supports optional features as mentioned at their github repository https://github.com/EHfive/pulseaudio-modules-bt

For now I created at my local system some of them, and works fine under my setup.

Please review my patches if makes sense for you.

Thanks.

Reproducible: Always

Steps to Reproduce:
1.Try to emerge pulseaudio-modules-bt
2.See many dependencies you don't want
3.Profit.
Actual Results:  
Ebuild forces you to install stuff not required

Expected Results:  
Should follow optional dependencies as expected
Comment 1 Pablo Cholaky 2020-03-22 01:36:21 UTC
Created attachment 624134 [details]
pulseaudio-modules-bt-1.3-r1 proposal
Comment 2 Pablo Cholaky 2020-03-22 01:36:43 UTC
Created attachment 624136 [details]
Proposal metadata.xml
Comment 3 Jonas Stein gentoo-dev 2020-03-23 01:17:51 UTC
A bot can look for additional mistakes, if you upload a PR via github
Comment 4 Pacho Ramos gentoo-dev 2020-03-23 09:32:43 UTC
Are they all automagic dependencies?
https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies
Comment 5 Pablo Cholaky 2020-03-25 09:21:35 UTC
Hi,

I just fixed the dependencies as expeted at github.

Also applied minor suggestions https://github.com/gentoo/gentoo/pull/15067
Comment 6 Larry the Git Cow gentoo-dev 2020-04-01 05:33:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b50033ecb5e30204457b16c251c7b7cf798f0673

commit b50033ecb5e30204457b16c251c7b7cf798f0673
Author:     Pablo Cholaky <waltercool@slash.cl>
AuthorDate: 2020-03-23 05:17:28 +0000
Commit:     Jason A. Donenfeld <zx2c4@gentoo.org>
CommitDate: 2020-04-01 05:33:17 +0000

    media-sound/pulseaudio-modules-bt: add USE flags
    
    Closes: https://bugs.gentoo.org/713878
    Signed-off-by: Pablo Cholaky <waltercool@slash.cl>
    Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org>

 media-sound/pulseaudio-modules-bt/metadata.xml     | 29 +++++++++++++++++-----
 ....ebuild => pulseaudio-modules-bt-1.3-r1.ebuild} | 22 ++++++++++++----
 .../pulseaudio-modules-bt-9999.ebuild              | 22 ++++++++++++----
 3 files changed, 57 insertions(+), 16 deletions(-)