Bug 713876 – app-emulation/xen-4.13.0: builds qemu even though use flag is not set

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sven 2020-03-22 00:16:32 UTC]

I have

[ebuild   R   ~] app-emulation/xen-tools-4.13.0-r2:0/4.13::gentoo  USE="pam pygrub python screen -api -debug -doc -flask -hvm -ipxe -ocaml -ovmf -qemu -qemu-traditional -rombios -sdl -static-libs -system-ipxe -system-qemu -system-seabios" PYTHON_SINGLE_TARGET="python3_6" 0 KiB


and qemu is still built. It took a long time.

I only have PV and PVH guests. To minimize downtime I'd really prefer to not build qemu. As you can see no qemu related use flags are set.

Reproducible: Always

Steps to Reproduce:
1. emerge xen-tools 4.13 with only use flags pam pygrub python and screen set.
2. observe that qemu is being built
3. verify with equery f xen-tools that qemu was indeed installed
Actual Results:  
qemu is built/installed

Expected Results:  
qemu should not be built/installed

[Comment 1 Tomáš Mózes 2020-04-15 08:50:00 UTC]

Please copy the recent 4.13 xen-tools ebuild into your local overlay and change this:
--- /usr/portage/app-emulation/xen-tools/xen-tools-4.13.0-r2.ebuild     2020-03-02 11:09:40.000000000 +0000
+++ xen-tools-4.13.0-r3.ebuild  2020-04-15 08:43:44.378212045 +0000
@@ -319,7 +319,7 @@
                fi
        else
                # Don't bother with qemu, only needed for fully virtualised guests
-               sed -e "s:install-tools\: tools/qemu-xen-traditional-dir:install-tools\: :g" -i Makefile || die
+               sed -i '/SUBDIRS-$(CONFIG_QEMU_XEN)/s/^/#/g' tools/Makefile || die
        fi

        # Reset bash completion dir; Bug 472438

This has taken the build time from 5m20s -> 2m16s. Please report back if it works in your setup, thanks.

[Comment 2 Tomáš Mózes 2020-04-28 12:03:29 UTC]

Ping Sven

[Comment 3 Sven 2020-04-29 08:33:24 UTC]

pong!

Tested it, and it works for me as well. The build time reduced drastically and all qemu files are gone.

[Comment 4 Larry the Git Cow 2020-05-25 14:21:30 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab132ad91fa4e41eca3bc48eebae586c6ba58a11

commit ab132ad91fa4e41eca3bc48eebae586c6ba58a11
Author:     Tomáš Mózes <[e-mail]>
AuthorDate: 2020-05-19 10:45:43 +0000
Commit:     Yixun Lan <[e-mail]>
CommitDate: 2020-05-25 14:20:03 +0000

    app-emulation/xen-tools: bump to 4.12.3
    
    Closes: https://bugs.gentoo.org/722930
    Closes: https://bugs.gentoo.org/713876
    Closes: https://github.com/gentoo/gentoo/pull/15857
    Signed-off-by: Tomáš Mózes <[e-mail]>
    Signed-off-by: Yixun Lan <[e-mail]>

 app-emulation/xen-tools/Manifest                  |   2 +
 app-emulation/xen-tools/files/gentoo-patches.conf |  14 +
 app-emulation/xen-tools/xen-tools-4.12.3.ebuild   | 500 ++++++++++++++++++++++
 3 files changed, 516 insertions(+)

[Comment 5 Tomáš Mózes 2020-05-25 15:40:22 UTC]

(In reply to Sven from comment #3)
> pong!
> 
> Tested it, and it works for me as well. The build time reduced drastically
> and all qemu files are gone.

Thanks for testing, applied to latest xen.