Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 713774 - media-fonts/jetbrains-mono-1.0.3 : FileNotFoundError: [Errno 2] No such file or directory: b*.ttf
Summary: media-fonts/jetbrains-mono-1.0.3 : FileNotFoundError: [Errno 2] No such file ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jan Henke
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-21 11:14 UTC by Toralf Förster
Modified: 2020-03-25 14:47 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.62 KB, text/plain)
2020-03-21 11:14 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,98.17 KB, text/plain)
2020-03-21 11:14 UTC, Toralf Förster
Details
environment (environment,24.48 KB, text/plain)
2020-03-21 11:14 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,11.39 KB, application/x-bzip)
2020-03-21 11:14 UTC, Toralf Förster
Details
media-fonts:jetbrains-mono-1.0.3:20200321-090851.log (media-fonts:jetbrains-mono-1.0.3:20200321-090851.log,2.44 KB, text/plain)
2020-03-21 11:14 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,8.26 KB, application/x-bzip)
2020-03-21 11:14 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-03-21 11:14:30 UTC
  File /usr/lib/portage/python3.6/doins.py, line 195, in run
    sstat = os.stat(source)
FileNotFoundError: [Errno 2] No such file or directory: b*.ttf
 * ERROR: media-fonts/jetbrains-mono-1.0.3::gentoo failed (install phase):
 *   doins failed
 * 

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma_systemd-20200318-121516

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.3.0 *
clang version 10.0.0 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/10/bin
/usr/lib/llvm/10
10.0.0
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.41.1
  [2]   rust-1.41.1 *
The following VMs are available for generation-2:
*)	IcedTea JDK 3.14.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.0.2

timestamp of HEAD at this tinderbox image:
/var/db/repos/gentoo	Sat 21 Mar 2020 07:08:40 AM UTC

emerge -qpvO media-fonts/jetbrains-mono
[ebuild  N    ] media-fonts/jetbrains-mono-1.0.3  USE="X"
Comment 1 Toralf Förster gentoo-dev 2020-03-21 11:14:33 UTC
Created attachment 623760 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-03-21 11:14:36 UTC
Created attachment 623762 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-03-21 11:14:39 UTC
Created attachment 623764 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-03-21 11:14:41 UTC
Created attachment 623766 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-03-21 11:14:44 UTC
Created attachment 623768 [details]
media-fonts:jetbrains-mono-1.0.3:20200321-090851.log
Comment 6 Toralf Förster gentoo-dev 2020-03-21 11:14:47 UTC
Created attachment 623770 [details]
temp.tbz2
Comment 7 Jan Henke 2020-03-22 09:30:52 UTC
I cannot reproduce this issue locally. Also none of the log files gave me any insight.

Can you give a tree view of the build directory just before the error occurs? Otherwise I feel there is not much I can do here.
Comment 8 Joonas Niilola gentoo-dev 2020-03-22 11:14:46 UTC
I'm sure this is somehow related (again) to fonts.eclass update. 
https://gitweb.gentoo.org/repo/gentoo.git/log/eclass/font.eclass

but don't currently have time to dig deeper.
Comment 9 Sebastian Pipping gentoo-dev 2020-03-24 16:02:16 UTC
Hi Jan,

the issue is that font_src_install calls "doins *.tff" from directory "${S}" rather than "${S}"/ttf.  To fix that, the ebuild needs a line: FONT_S="ttf" .

PS: Top reproduce, local "ebuild jetbrains-mono-1.0.3.ebuild manifest clean install" took me straight to the error.
Comment 10 Jan Henke 2020-03-24 18:36:23 UTC
Hi Sebastian,

that line already exists in the ebuild (line 19). So unfortunately this does not help in me regard of this bug.

Also "ebuild jetbrains-mono-1.0.3.ebuild manifest clean install" does not reproduce the error on my machine.
Comment 11 Jan Henke 2020-03-24 18:48:16 UTC
Okay, I now found the source of confusion. The line in question was added in commit https://github.com/gentoo/gentoo/commit/f69811f5167ac9df8c20abdfb86a94ee030b9eca to the 1.0.0 ebuild. Two days later I bump the version to 1.0.3 coping over the ebuild with the line. For reasons unknown to me (and also entirely unknown) the original commit was reverted in commit https://github.com/gentoo/gentoo/commit/a4234be897ea2aa03fe66bb8c05eb9b927bc22ed, but this time also removing that line from the 1.0.3 ebuild.

I still have the version with that line in my local overlay (which I use to test ebuild before creating PRs). That is why I could not reproduce this issue.

This still leads to the question, why was the commit reverted and why did the revert also change a file, which was not part of the original commit?
Comment 12 Sebastian Pipping gentoo-dev 2020-03-24 22:09:02 UTC
Interesting!

I'm adding ulm to CC now...


> This still leads to the question, why was the commit reverted and why did
> the revert also change a file, which was not part of the original commit?

From a closer look at the ebuilds, the two commits by ulm and the file structure extracted from the files, I believe we need:

- no FONT_S line for jetbrains-mono-1.0.0.ebuild
  (because .tff files reside in ${S}; status quo)

- FONT_S="ttf" for jetbrains-mono-1.0.3.ebuild
  (because .tff files reside in ${S}/ttf; yet to do)

I'm happy to make that happy if you agree it's the right fix.
Comment 13 Ulrich Müller gentoo-dev 2020-03-24 23:50:01 UTC
The reverts in media-fonts were following the font.eclass update for bug 613108. There were some conflicts, but I don't remember if there was one for this package. (Also I thought I had tested everything, but maybe I did only 1.0.0? Sorry for that.)

Anyway, I think that the ebuild for 1.0.3 should simply do S="${WORKDIR}/JetBrainsMono-${PV}/ttf", because it doesn't need anything from outside this directory.
Comment 14 Sebastian Pipping gentoo-dev 2020-03-25 00:24:44 UTC
(In reply to Ulrich Müller from comment #13)
> Anyway, I think that the ebuild for 1.0.3 should simply do
> S="${WORKDIR}/JetBrainsMono-${PV}/ttf", because it doesn't need anything
> from outside this directory.

I get the idea about adjusting ${S} and it should work.

It seems a bit more complex though and I would argue that FONT_S="ttf" is a better fit, semantically: FONT_S seems made for this very case.  I'm happy either way.  How should we go forward?
Comment 15 Ulrich Müller gentoo-dev 2020-03-25 05:36:58 UTC
It will work either way. I'd prefer adjusting S, because all relevant files are in the ttf subdir.
Comment 16 Jan Henke 2020-03-25 07:13:36 UTC
I am also fine with both ways. For the 1.0.4 ebuild (see the linked bug) I have just applied ulm's suggestion and set S="${WORKDIR}/JetBrainsMono-${PV}/ttf". I suggest to go for the same for the 1.0.3 ebuild.

Would either of you do that directly on the tree? Then we do not have to wait for a PR to get reviewed and merged.
Comment 17 Joonas Niilola gentoo-dev 2020-03-25 07:14:42 UTC
Please make a PR because you tested it works - I'll commit immediately today.
Comment 18 Sebastian Pipping gentoo-dev 2020-03-25 14:01:03 UTC
Alright, I'll take care of applying the ${S} approach now, give me a second.
Comment 19 Larry the Git Cow gentoo-dev 2020-03-25 14:08:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=132301c8b48fa0febc17563697215fdfd2c88e63

commit 132301c8b48fa0febc17563697215fdfd2c88e63
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2020-03-25 14:06:45 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2020-03-25 14:07:18 +0000

    media-fonts/jetbrains-mono: Fix 1.0.3 compilation
    
    .. by syncing ${S} with 1.0.4 ebuild.
    Closes: https://bugs.gentoo.org/713774
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-2.3.92, Repoman-2.3.20

 media-fonts/jetbrains-mono/jetbrains-mono-1.0.3.ebuild | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 20 Ulrich Müller gentoo-dev 2020-03-25 14:47:01 UTC
Thank you, and sorry again for the breakage.