713120 – media-video/aegisub w/ sys-devel/make-4.3: undefined reference to `agi::...'

Bug 713120 - media-video/aegisub w/ sys-devel/make-4.3: undefined reference to `agi::...'

Summary: media-video/aegisub w/ sys-devel/make-4.3: undefined reference to `agi::...'

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Nick Sarnie

URL:
Whiteboard:
Keywords:	PATCH, PullRequest

Depends on:
Blocks:	make-4.3
	Show dependency tree

Reported:	2020-03-18 08:28 UTC by Petr Zima
Modified:	2021-01-13 00:19 UTC (History)
CC List:	2 users (show)

See Also:	https://github.com/gentoo/gentoo/pull/15045 765133
Package list:
Runtime testing required:	---

Attachments
patch fixing the problem (aegisub-3.2.2_p20160518-fix-makefile.patch,729 bytes, patch) 2020-03-18 08:30 UTC, Petr Zima	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Petr Zima 2020-03-18 08:28:22 UTC

With make-4.3 build fails with:

media-video-aegisub-3.2.2_p20160518-r3/work/aegisub-3.2.2_p20160518/tools/repack-thes-dict.cpp:33: undefined reference to `agi::io::Open(boost::filesystem::path const&, bool)'
media-video-aegisub-3.2.2_p20160518-r3/work/aegisub-3.2.2_p20160518/tools/repack-thes-dict.cpp:34: undefined reference to `agi::io::Open(boost::filesystem::path const&, bool)'
media-video-aegisub-3.2.2_p20160518-r3/work/aegisub-3.2.2_p20160518/tools/repack-thes-dict.cpp:37: undefined reference to `agi::io::Save::Save(boost::filesystem::path const&, bool)'
...
collect2: error: ld returned 1 exit status

See upstream: https://github.com/Aegisub/Aegisub/issues/171

Comment 1 Petr Zima 2020-03-18 08:30:43 UTC

Created attachment 621162 [details, diff]
patch fixing the problem

https://github.com/Aegisub/Aegisub/pull/174

Comment 2 Nick Sarnie gentoo-dev

2020-03-18 21:32:43 UTC

Thanks for the patch, can you please create a pull request on github?

Comment 3 Larry the Git Cow gentoo-dev

2020-03-23 22:24:23 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c017bfe2f324f573dd2e604f75bb6899585489fe

commit c017bfe2f324f573dd2e604f75bb6899585489fe
Author:     Christophe Lermytte <gentoo@lermytte.be>
AuthorDate: 2020-03-21 18:51:14 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2020-03-23 22:23:04 +0000

    media-video/aegisub: revbump for patching Makefile to work with make-4.3
    
    upstream pull reqeust: https://github.com/Aegisub/Aegisub/pull/174
    
    Package-Manager: Portage-2.3.94, Repoman-2.3.21
    Bug: https://bugs.gentoo.org/713120
    X-Thanks: Petr Zima <zima@matfyz.cz>
    Signed-off-by: Christophe Lermytte <gentoo@lermytte.be>
    Closes: https://github.com/gentoo/gentoo/pull/15045
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 .../aegisub/aegisub-3.2.2_p20160518-r4.ebuild      | 150 +++++++++++++++++++++
 ...-3.2.2_p20160518-fix-makefile-for-make4.3.patch |  21 +++
 2 files changed, 171 insertions(+)

Comment 4 Petr Zima 2020-03-25 14:53:24 UTC

Thanks for preparing the pull-request and resolving the bug. I would do that myself but I was rather busy.

Comment 5 WGH 2021-01-12 13:22:09 UTC

Since make 4.3 was recently stalibized (#738316), it would make sense to stabilize the updated aegisub ebuild, too. Right now the stable one is broken.

Comment 6 Sam James archtester

2021-01-13 00:19:52 UTC

(In reply to WGH from comment #5)
> Since make 4.3 was recently stalibized (#738316), it would make sense to
> stabilize the updated aegisub ebuild, too. Right now the stable one is
> broken.

Please file a new bug for this