Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 713092 - media-gfx/shotwell-30.8 depends on media-libs/gexiv2 twice
Summary: media-gfx/shotwell-30.8 depends on media-libs/gexiv2 twice
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nicolas Bock
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-18 00:18 UTC by Ulenrich
Modified: 2020-04-14 09:49 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulenrich 2020-03-18 00:18:09 UTC
Found a quality issue of the shotwell ebuild:
media-gfx/shotwell-30.8 depends on media-libs/gexiv2 twice and therefore 
emerge misses the second restraint with gexiv2[vala]:
---
BDEPEND=
        $(vala_depend)
        dev-libs/appstream-glib
        dev-util/itstool
        >=sys-devel/gettext-0.19.8
        virtual/pkgconfig
        net-libs/libsoup:2.4[vala]
        media-libs/gexiv2[vala]

Having had emerged media-libs/gexiv2 -vala
the following emerge of shotwell failed:
---
error: Package `gexiv2' not found in specified Vala API directories or GObject-Introspection GIR directories
Compilation failed: 1 error(s), 0 warning(s)
ninja: build stopped: subcommand failed.
 * ERROR: media-gfx/shotwell-0.30.8::gentoo failed (compile phase):
 *   ninja -v -j1 -l0 -C /srv/portage/media-gfx/shotwell-0.30.8/work/shotwell-0.30.8-build failed

Then adjusting the USE vala for gexiv2 
got through the emerge of shotwell successfully
Comment 1 Mart Raudsepp gentoo-dev 2020-04-14 09:26:48 UTC
I don't see an issue here in deps.
gexiv2 is needed at runtime, and gexiv2[vala] is only needed at buildtime (vala gets compiled to C and then compiled with C compilers - the gexiv2 vapi file isn't needed at runtime).

Not sure why this wouldn't be properly effective then, to force a rebuild of gexiv2 with vala enabled before shotwell is configured/compiled.
Comment 2 Mart Raudsepp gentoo-dev 2020-04-14 09:31:46 UTC
Ok, the problem is that I have converted the ebuild to EAPI-7, but failed to actually change EAPI=6 to EAPI=7, so it's just missing it in build depends, along with everything else in there (but you happen to have all those others installed).
Comment 3 Larry the Git Cow gentoo-dev 2020-04-14 09:49:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7455cb000b76eccc082cae9beebdf630527c39a9

commit 7455cb000b76eccc082cae9beebdf630527c39a9
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2020-04-14 09:35:53 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2020-04-14 09:49:15 +0000

    media-gfx/shotwell: fix build depends
    
    Closes: https://bugs.gentoo.org/713092
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 .../shotwell/{shotwell-0.30.8.ebuild => shotwell-0.30.8-r1.ebuild}    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)