Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 713034 - net-p2p/retroshare: Drop dependency on gnome-base/libgnome-keyring
Summary: net-p2p/retroshare: Drop dependency on gnome-base/libgnome-keyring
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gioacchino Mazzurco
URL: https://github.com/RetroShare/RetroSh...
Whiteboard:
Keywords:
Depends on: 726504
Blocks: 713010
  Show dependency tree
 
Reported: 2020-03-17 19:03 UTC by Matt Turner
Modified: 2020-06-18 16:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated ebuild (retroshare-0.6.5.ebuild,3.86 KB, text/plain)
2020-04-21 08:00 UTC, Gioacchino Mazzurco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2020-03-17 19:03:53 UTC
gnome-base/libgnome-keyring is deprecated and replaced with libsecret. The commit in $URL, which is in v0.6.5, switches to using libsecret first.
Comment 1 Larry the Git Cow gentoo-dev 2020-03-22 22:09:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2db918ff33b15be6731b3cd87266b7f62efeacf3

commit 2db918ff33b15be6731b3cd87266b7f62efeacf3
Author:     Jory Pratt <anarchy@gentoo.org>
AuthorDate: 2020-03-22 22:05:48 +0000
Commit:     Jory Pratt <anarchy@gentoo.org>
CommitDate: 2020-03-22 22:09:19 +0000

    profiles/features/musl: add locale.alias to INSTALL_MASK
    
    Closes: https://bugs.gentoo.org/713474
    Closes: https://bugs.gentoo.org/713762
    Closes: https://bugs.gentoo.org/713826
    Closes: https://bugs.gentoo.org/713964
    Closes: https://bugs.gentoo.org/713034
    
    Signed-off-by: Jory Pratt <anarchy@gentoo.org>

 profiles/features/musl/make.defaults | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Jory A. Pratt gentoo-dev 2020-03-22 22:16:01 UTC
Sorry was given a bad bug number :/
Comment 3 Matt Turner gentoo-dev 2020-04-14 02:16:07 UTC
Ping?
Comment 4 Gioacchino Mazzurco 2020-04-14 08:01:06 UTC
(In reply to Matt Turner from comment #3)
> Ping?

I don't use this feature and have not gnome on my system so it is difficult for me to test if just by changing the dependencies it would works, could you try on your system and report back?
Comment 5 Matt Turner gentoo-dev 2020-04-15 00:44:07 UTC
You don't need a gnome desktop to build test a dependency, much less to to fix a dependency.

libsecret depends on glib and a couple of other things you already have installed. retroshare's gnome-keyring USE flag only depends on libgnome-keyring, which should be changed to libsecret.

I don't think this is difficult...
Comment 6 Gioacchino Mazzurco 2020-04-21 08:00:48 UTC
Created attachment 634002 [details]
Updated ebuild

Please test this ebuild and report back, if everything goes fine I'll open a pull request with it
Comment 7 Matt Turner gentoo-dev 2020-04-26 19:09:56 UTC
Yes, that looks good.
Comment 8 Larry the Git Cow gentoo-dev 2020-04-28 17:47:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=822f29a0137f968a0f07f7753e08d52978d9e859

commit 822f29a0137f968a0f07f7753e08d52978d9e859
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2020-04-28 17:46:00 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-04-28 17:46:03 +0000

    net-p2p/retroshare: Switch dependency to libsecret
    
    Bug: https://bugs.gentoo.org/713034
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 net-p2p/retroshare/retroshare-0.6.5.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 9 Matt Turner gentoo-dev 2020-04-28 17:49:17 UTC
(In reply to Gioacchino Mazzurco from comment #6)
> Created attachment 634002 [details]
> Updated ebuild
> 
> Please test this ebuild and report back, if everything goes fine I'll open a
> pull request with it

Since it's been a week, I checked github to see if there was a pull request but didn't find one. So I downloaded the ebuild and realized that it was based on gentoo.git from more than two months ago...

So I just made the change myself. :(

We'll leave the bug open until there are no versions of retroshare that has a dependency on libgnome-keyring.
Comment 10 Gioacchino Mazzurco 2020-04-29 11:30:57 UTC
thanks Matt
Comment 11 Matt Turner gentoo-dev 2020-04-29 17:13:48 UTC
Like I said...

> We'll leave the bug open until there are no versions of retroshare that has a dependency on libgnome-keyring.
Comment 12 Matt Turner gentoo-dev 2020-06-18 16:59:49 UTC
commit bc4e11b46948e7d3fb18e80293c639988fc4869d
Author: Andreas Sturmlechner <asturm@gentoo.org>
Date:   Thu May 21 19:14:15 2020 +0200

    net-p2p/retroshare: Drop 0.6.3-r2 and 0.6.4-r1
    
    Bug: https://bugs.gentoo.org/697578
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>