Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 712896 - media-libs/mesa[-gallium] - pkg_setup calls llvm_pkg_setup incorrectly
Summary: media-libs/mesa[-gallium] - pkg_setup calls llvm_pkg_setup incorrectly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-16 15:31 UTC by Brian Evans (RETIRED)
Modified: 2020-03-19 22:30 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Evans (RETIRED) gentoo-dev 2020-03-16 15:31:09 UTC 
in pkg_setup, this code exists

if use llvm; then
    llvm_pkg_setup
fi

However, the dependencies that are being checked for are only installed for mesa if the gallium USE is also enabled so this can easily fail.

I suggest changing it to:

if use gallium && use llvm; then
    llvm_pkg_setup
fi
Comment 1 Larry the Git Cow gentoo-dev 2020-03-19 22:30:55 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a81af4d27ea251c534cc1ffa6b4812f5950f706

commit 8a81af4d27ea251c534cc1ffa6b4812f5950f706
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2020-03-19 22:17:13 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-03-19 22:30:43 +0000

    media-libs/mesa: Only call llvm_pkg_setup with USE="gallium llvm"
    
    Closes: https://bugs.gentoo.org/712896
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 media-libs/mesa/mesa-19.3.5.ebuild    | 2 +-
 media-libs/mesa/mesa-20.0.1-r1.ebuild | 2 +-
 media-libs/mesa/mesa-20.0.2.ebuild    | 2 +-
 media-libs/mesa/mesa-9999.ebuild      | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)