Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 712594 - dev-vcs/mercurial: ERROR: dev-vcs/mercurial-5.2.2-r1::gentoo failed (compile phase): strip-flags takes no arguments
Summary: dev-vcs/mercurial: ERROR: dev-vcs/mercurial-5.2.2-r1::gentoo failed (compile ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-14 23:30 UTC by Sergei Trofimovich (RETIRED)
Modified: 2020-03-16 11:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich (RETIRED) gentoo-dev 2020-03-14 23:30:29 UTC
I noticed that mercurial calls 'strip-flags' with parameters and added https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f8669c1089dd9962d946c7be46a17fdd1cd2ebd8

In the following code

    python_compile() {
        strip-flags -ftracer -ftree-vectorize
        ...
    }

before the change this code effectively called

    python_compile() {
        strip-flags
        ...
    }

which strips most flags in CFLAGS. This probably is not what you want. You probably need:

    python_compile() {
        filter-flags -ftracer -ftree-vectorize
        ...
    }

or something more future-proof:

    python_compile() {
        append-flags $(test-flags-CC -no-ftracer -fno-tree-vectorize)
        ...
    }

Or even remove this stale filtering.
Comment 1 Larry the Git Cow gentoo-dev 2020-03-15 09:28:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b55991445032636c59c63aab64642dab4957a2af

commit b55991445032636c59c63aab64642dab4957a2af
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-03-15 09:28:00 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-03-15 09:28:22 +0000

    dev-vcs/mercurial: drop 'strip-flags' parameters, bug #712594
    
    This is not a fix for bug #712594.
    
    The code change only gets ebuild to the state it was before
    f8669c1089dd9962d946c7be46 "flag-o-matic.eclass: add assertions
    around argument counts" was submitted.
    
    We'll need a proper fix. I've left a TODO in ebuild.
    
    Bug: https://bugs.gentoo.org/712594
    Package-Manager: Portage-2.3.94, Repoman-2.3.20
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 dev-vcs/mercurial/mercurial-4.6.2.ebuild    | 2 +-
 dev-vcs/mercurial/mercurial-4.9-r2.ebuild   | 2 +-
 dev-vcs/mercurial/mercurial-4.9.1.ebuild    | 4 ++--
 dev-vcs/mercurial/mercurial-5.0.2.ebuild    | 4 ++--
 dev-vcs/mercurial/mercurial-5.1.2.ebuild    | 2 +-
 dev-vcs/mercurial/mercurial-5.2.2-r1.ebuild | 2 +-
 dev-vcs/mercurial/mercurial-9999.ebuild     | 2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)
Comment 2 Samuel Bernardo 2020-03-15 22:57:03 UTC
Same problem here.
Comment 3 Samuel Bernardo 2020-03-15 23:54:37 UTC
(In reply to Samuel Bernardo from comment #2)
> Same problem here.

I just tested the proposed patch installing mercurial-5.2.2-r1 and it worked as expected.
Since this is blocking ebuilds such as layman, I need to mask it from gentoo repository.
Comment 4 Larry the Git Cow gentoo-dev 2020-03-16 11:03:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a0eb5cfdc61e517ac28c13cd3832e92b96fd1a3

commit 7a0eb5cfdc61e517ac28c13cd3832e92b96fd1a3
Author:     Cédric Krier <cedk@gentoo.org>
AuthorDate: 2020-03-15 10:24:28 +0000
Commit:     Cédric Krier <cedk@gentoo.org>
CommitDate: 2020-03-16 11:03:14 +0000

    dev-vcs/mercurial: Use filter-flags instead of strip-flags
    
    Closes: https://bugs.gentoo.org/712594
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Cédric Krier <cedk@gentoo.org>

 dev-vcs/mercurial/mercurial-4.6.2.ebuild    | 2 +-
 dev-vcs/mercurial/mercurial-4.9-r2.ebuild   | 2 +-
 dev-vcs/mercurial/mercurial-4.9.1.ebuild    | 2 +-
 dev-vcs/mercurial/mercurial-5.0.2.ebuild    | 2 +-
 dev-vcs/mercurial/mercurial-5.1.2.ebuild    | 2 +-
 dev-vcs/mercurial/mercurial-5.2.2-r1.ebuild | 2 +-
 dev-vcs/mercurial/mercurial-9999.ebuild     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)