Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 712040 - net-misc/openssh: RDEPEND=sys-apps/shadow breaks prefix-guest
Summary: net-misc/openssh: RDEPEND=sys-apps/shadow breaks prefix-guest
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-10 08:39 UTC by Michael Haubenwallner (RETIRED)
Modified: 2020-03-16 12:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch to not depend on sys-apps/shadow when USE=prefix-guest (openssh-shadow.diff,462 bytes, patch)
2020-03-10 08:39 UTC, Michael Haubenwallner (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Haubenwallner (RETIRED) gentoo-dev 2020-03-10 08:39:44 UTC
Created attachment 617882 [details, diff]
proposed patch to not depend on sys-apps/shadow when USE=prefix-guest

In Prefix CI, Prefix Guest does break since this commit:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d87f94f04c4db1b99e372162fcd16b8b2f99fdaa
which does:
  RDEPEND="
 -       userland_GNU? ( virtual/shadow )
 +       userland_GNU? ( sys-apps/shadow )
  "

The error now is:
 * running emerge -u system
 Calculating dependencies  ... done!

 !!! All ebuilds that could satisfy "sys-apps/shadow" have been masked.
 !!! One of the following masked packages is required to complete your request:
 - sys-apps/shadow-4.8.1-r1::gentoo_prefix (masked by: missing keyword) 
 - sys-apps/shadow-4.8-r3::gentoo_prefix (masked by: missing keyword) 
 - sys-apps/shadow-4.7-r2::gentoo_prefix (masked by: missing keyword) 
 - sys-apps/shadow-4.6::gentoo_prefix (masked by: missing keyword) 
 
 (dependency required by "net-misc/openssh-8.2_p1-r5::gentoo_prefix" [ebuild])
 (dependency required by "virtual/ssh-0::gentoo_prefix[-minimal]" [ebuild])
 (dependency required by "@system" [argument])

Note that virtual/shadow does have:
 RDEPEND="!prefix? ( || ( >=sys-apps/shadow-4.1 sys-apps/hardened-shadow ) )"

@Benda, does Standalone Prefix use sys-apps/shadow, and this should read
 RDEPEND="!prefix-guest? ( sys-apps/shadow )" ?
Comment 1 Benda Xu gentoo-dev 2020-03-10 09:44:49 UTC
(In reply to Michael Haubenwallner from comment #0)

> @Benda, does Standalone Prefix use sys-apps/shadow, and this should read
>  RDEPEND="!prefix-guest? ( sys-apps/shadow )" ?

This would be fine.

Standalone Prefix does not use sys-apps/shadow, but installing it is a lazy way to meet the dependencies ;)
Comment 2 Michael Haubenwallner (RETIRED) gentoo-dev 2020-03-10 09:59:35 UTC
@base-system: OK to push? For latest only or all ebuilds?
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2020-03-10 10:03:51 UTC
(In reply to Michael Haubenwallner from comment #2)
> @base-system: OK to push? For latest only or all ebuilds?

Okay for all affected ebuilds
Comment 4 Larry the Git Cow gentoo-dev 2020-03-10 12:36:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dcbc43341eda8aa75b81c1837f7d9dbc04dc613e

commit dcbc43341eda8aa75b81c1837f7d9dbc04dc613e
Author:     Michael Haubenwallner <haubi@gentoo.org>
AuthorDate: 2020-03-10 09:55:52 +0000
Commit:     Michael Haubenwallner <haubi@gentoo.org>
CommitDate: 2020-03-10 12:36:18 +0000

    net-misc/openssh: no sys-apps/shadow in prefix-guest
    
    Closes: https://bugs.gentoo.org/712040
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Michael Haubenwallner <haubi@gentoo.org>

 net-misc/openssh/openssh-7.5_p1-r5.ebuild  | 2 +-
 net-misc/openssh/openssh-7.7_p1-r10.ebuild | 2 +-
 net-misc/openssh/openssh-7.9_p1-r5.ebuild  | 2 +-
 net-misc/openssh/openssh-8.0_p1-r5.ebuild  | 2 +-
 net-misc/openssh/openssh-8.1_p1-r3.ebuild  | 2 +-
 net-misc/openssh/openssh-8.2_p1-r5.ebuild  | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
Comment 5 Benda Xu gentoo-dev 2020-03-16 08:36:37 UTC
(In reply to Benda Xu from comment #1)
> (In reply to Michael Haubenwallner from comment #0)
> 
> > @Benda, does Standalone Prefix use sys-apps/shadow, and this should read
> >  RDEPEND="!prefix-guest? ( sys-apps/shadow )" ?
> 
> This would be fine.
> 
> Standalone Prefix does not use sys-apps/shadow, but installing it is a lazy
> way to meet the dependencies ;)

I am sorry.  After digging into this, only net-misc/openssh migrated away from virtual/shadow.  Prefix standalone avoid drawing in sys-apps/shadow.

@base-system, may I replace 'prefix-guest' with 'prefix' in all the ebuilds?
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2020-03-16 10:30:42 UTC
(In reply to Benda Xu from comment #5)
> (In reply to Benda Xu from comment #1)
> > (In reply to Michael Haubenwallner from comment #0)
> > 
> > > @Benda, does Standalone Prefix use sys-apps/shadow, and this should read
> > >  RDEPEND="!prefix-guest? ( sys-apps/shadow )" ?
> > 
> > This would be fine.
> > 
> > Standalone Prefix does not use sys-apps/shadow, but installing it is a lazy
> > way to meet the dependencies ;)
> 
> I am sorry.  After digging into this, only net-misc/openssh migrated away
> from virtual/shadow.  Prefix standalone avoid drawing in sys-apps/shadow.
> 
> @base-system, may I replace 'prefix-guest' with 'prefix' in all the ebuilds?

Yes, please proceed.
Comment 7 Larry the Git Cow gentoo-dev 2020-03-16 12:41:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=846c38951ad42771f83af7db9e4d66c6fa31294c

commit 846c38951ad42771f83af7db9e4d66c6fa31294c
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2020-03-16 12:40:20 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2020-03-16 12:41:25 +0000

    net-misc/openssh: no sys-apps/shadow in prefix.
    
    Closes: https://bugs.gentoo.org/712040
    Package-Manager: Portage-2.3.88, Repoman-2.3.18
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 net-misc/openssh/openssh-7.5_p1-r5.ebuild  | 2 +-
 net-misc/openssh/openssh-7.7_p1-r10.ebuild | 2 +-
 net-misc/openssh/openssh-7.9_p1-r5.ebuild  | 2 +-
 net-misc/openssh/openssh-8.0_p1-r5.ebuild  | 2 +-
 net-misc/openssh/openssh-8.1_p1-r3.ebuild  | 2 +-
 net-misc/openssh/openssh-8.2_p1-r5.ebuild  | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)