Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 711972 - mail-filter/rspamd-2.5: version bump? upstream has fixes for neural.lua and phishing.lua
Summary: mail-filter/rspamd-2.5: version bump? upstream has fixes for neural.lua and p...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Roessner
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-03-09 17:09 UTC by Kim B. Sindalsen
Modified: 2020-04-04 08:06 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kim B. Sindalsen 2020-03-09 17:09:41 UTC
Both plugins/lua/neural.lua and plugins/lua/phishing.lua has been updated in GIT to fix some errors.

Error with plain 2.4 neural.lua:
call to (NEURAL_LEARN) failed (2): /usr/share/rspamd/plugins/neural.lua:517: attempt to index field 'ann' (a nil value); trace: [1]:{/usr/share/rspamd/plugins/neural.lua:517 - ann_push_task_result [Lua]}; [2]:{/usr/share/rspamd/plugins/neural.lua:1212 - [Lua]};

Error with plain 2.4 phishing.lua (using openphish):
<>; ; rspamd_lua_check_udata_common: lua type error: expected rspamd{text} at position 2, but userdata has userdata metatable; trace:  [1]:{/usr/share/rspamd/plugins/phishing.lua:438 - <unknown> [Lua]}; stack(2): [1: ud=(NULL)] [2: ud=userdata]

Reproducible: Always




Replacing files in /usr/share/rspamd/plugins/ with files from GIT (src/plugins/lua/neural.lua and phishing.lua) fixes the error.

According to mailing list fixed in 2.4-2 release, but don't know how/where to download/test.
Comment 1 Jonas Stein gentoo-dev 2020-03-14 19:31:46 UTC
The source notes even version 2.5 on https://github.com/rspamd/rspamd 
however it was not yet released?
The maintainers will know it better.
Comment 2 Petr Vaněk gentoo-dev 2020-03-15 17:59:09 UTC
Version 2.5 has not been released yet, I'll make version bump as soon as it will be available.

It is a little bit unfortunate with 2.4-2 as it is debian? package release made by Vsevolod Stakhov himself but I was unable to find which fixes he applied. I don't understand why he does not publish those changes in git.

I currently see those possibilities:
1) let's pickup fixes for 2.4 and I'll do the revbump,
2) let's wait for 2.5 to be released.
Comment 3 Stijn Tintel 2020-04-02 23:31:42 UTC
FYI, 2.5 was released yesterday.
Comment 4 Petr Vaněk gentoo-dev 2020-04-03 07:59:53 UTC
I know, I submitted the PR 15198 with version bump few hours after the announcement.
Comment 5 Larry the Git Cow gentoo-dev 2020-04-04 08:06:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6b8f52d70569ce5009cf8dff1576f6dceb12022

commit f6b8f52d70569ce5009cf8dff1576f6dceb12022
Author:     Petr Vaněk <arkamar@atlas.cz>
AuthorDate: 2020-04-01 14:38:30 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-04-04 07:51:31 +0000

    mail-filter/rspamd: bump to 2.5
    
    Closes: https://bugs.gentoo.org/711972
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-filter/rspamd/Manifest          |   1 +
 mail-filter/rspamd/rspamd-2.5.ebuild | 114 +++++++++++++++++++++++++++++++++++
 2 files changed, 115 insertions(+)