Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 711698 - app-misc/goobook-3.4: missing dependencies
Summary: app-misc/goobook-3.4: missing dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Kalin KOZHUHAROV
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-03-06 15:34 UTC by Marc Schiffbauer
Modified: 2020-03-09 05:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge--info,7.78 KB, text/plain)
2020-03-06 15:34 UTC, Marc Schiffbauer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Schiffbauer gentoo-dev 2020-03-06 15:34:36 UTC
Created attachment 617338 [details]
emerge --info

There is a dependency missing. AFter installing oauth2client everything is fine


~ $ goobook
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.6/goobook", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 3251, in <module>
    @_call_aside
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 3235, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 3264, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 583, in _build_master
    ws.require(__requires__)
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib64/python3.6/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'oauth2client<5.0.0dev,>=1.5.0' distribution was not found and is required by goobook
 ~ $
Comment 1 Kalin KOZHUHAROV 2020-03-06 21:24:19 UTC
Thanks for that, I'll try to fix it ASAP.

Since dev-python/oauth2client is a direct dependency of dev-python/google-api-python-client, which is a direct dependency of app-misc/goobook-3.4, I decided not to include it (there is a comment in the ebuild).

How did you end up with that config? depclean probably? But shouldn't be dev-python/oauth2client be required by dev-python/google-api-python-client anyway?

I think this is quite hard to achieve configuration in normal use, so I will just fix the ebuild without new release number.

I will add all deps as specified by the package:

$ cat /usr/lib64/python3.6/site-packages/goobook-3.4-py3.6.egg-info/requires.txt
google-api-python-client>=1.6.4
simplejson>=2.1.0
oauth2client<5.0.0dev,>=1.5.0
Comment 2 Marc Schiffbauer gentoo-dev 2020-03-06 21:58:18 UTC
(In reply to Kalin KOZHUHAROV from comment #1)
> 
> How did you end up with that config? depclean probably? But shouldn't be
> dev-python/oauth2client be required by dev-python/google-api-python-client
> anyway?
> 

Seems like newer dev-python/google-api-python-client has dropped DEPEND on oauth2
in version >= 1.7.0
Comment 3 Marc Schiffbauer gentoo-dev 2020-03-06 22:00:07 UTC
BTW: I'd recomment to revbump because --depclean killed oauth2 package. Nothing strange here.
Comment 4 Kalin KOZHUHAROV 2020-03-07 00:27:47 UTC
OK, agree with the revbump, just updated the PR on github, hopefully someone will pick it up quickly.

Just for my notes, how to reproduce:
 emerge -Ca dev-python/oauth2client
 emerge ">=dev-python/google-api-python-client-1.7"
 emerge "=app-misc/goobook-3.4"

<=dev-python/google-api-python-client-1.7.0 (added 2019-07-12T10:21:29-07:00, commit df9de02ecaf987d4c95eb06069820c6994f371b9), google-api-python-client was depending on dev-python/oauth2client; then not.
Comment 5 Larry the Git Cow gentoo-dev 2020-03-09 05:55:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=86da8c1dfbfdcadaa25670a1f2b793328ed1d8fb

commit 86da8c1dfbfdcadaa25670a1f2b793328ed1d8fb
Author:     Kalin KOZHUHAROV <me.kalin@gmail.com>
AuthorDate: 2020-03-07 00:07:17 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-03-09 05:55:11 +0000

    app-misc/goobook: revbump to fix deps
    
    Apparently >=dev-python/google-api-python-client-1.7 has dropped
    dependency on dev-python/oauth2client, so this will break systems when
    doing depclean
    
    Closes: https://bugs.gentoo.org/711698
    Signed-off-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Closes: https://github.com/gentoo/gentoo/pull/14853
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-misc/goobook/{goobook-3.4.ebuild => goobook-3.4-r1.ebuild} | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)