Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 711550 - dev-util/geany-plugins-1.36-r1 gitchangebar plugin compile error against dev-libs/libgit2-0.99.0-r1
Summary: dev-util/geany-plugins-1.36-r1 gitchangebar plugin compile error against dev-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chris Mayo
URL:
Whiteboard:
Keywords: PullRequest
: 713410 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-03-04 19:04 UTC by Steve Arnold
Modified: 2020-04-10 14:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Arnold archtester gentoo-dev 2020-03-04 19:04:28 UTC
Relevant log data:

Making all in src
make[3]: Entering directory '/var/tmp/portage/dev-util/geany-plugins-1.36-r1/work/geany-plugins-1.36/git-changebar/src'
/bin/sh ../../libtool  --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..   -DG_LOG_DOMAIN=\"GitChangeBar\"  -DLOCALEDIR=\""/usr/share/locale"\" -DPREFIX=\""/usr"\" -DDOCDIR=\""/usr/share/doc
/geany-plugins-1.36-r1"\" -DGEANYPLUGINS_DATADIR=\""/usr/share"\" -DPKGDATADIR=\""/usr/share/geany-plugins"\" -DLIBDIR=\""/usr/lib64"\" -DPKGLIBDIR=\""/usr/lib64/geany-plugins"\" -DPLUGINDATADIR=\""/usr/share/geany-plu
gins/git-changebar"\" -DPLUGINDOCDIR=\""/usr/share/doc/geany-plugins-1.36-r1/git-changebar"\" -DPLUGINLIBDIR=\""/usr/lib64/geany-plugins/git-changebar"\" -DPLUGIN="\"git-changebar\"" -DGTK -I/usr/include/geany -I/usr/i
nclude/geany/tagmanager -I/usr/include/geany/scintilla -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/fribidi -I/usr/inc
lude/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/uuid -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include
/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -pthread   -I/usr/include/gtk-3.0 -I/usr/include/
pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/uuid -I/usr/includ
e/libdrm -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/u
sr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -pthread -Iinclude  -march=native -O2 -pipe -flto -ftree-vectorize -ftree-loop-distribution -fvect-cost-model=cheap -c -o git_changebar_la-gcb
-plugin.lo `test -f 'gcb-plugin.c' || echo './'`gcb-plugin.c
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../.. -DG_LOG_DOMAIN=\"GitChangeBar\" -DLOCALEDIR=\"/usr/share/locale\" -DPREFIX=\"/usr\" -DDOCDIR=\"/usr/share/doc/geany-plugins-1.36-r1\" -DGEANYPLUGIN
S_DATADIR=\"/usr/share\" -DPKGDATADIR=\"/usr/share/geany-plugins\" -DLIBDIR=\"/usr/lib64\" -DPKGLIBDIR=\"/usr/lib64/geany-plugins\" -DPLUGINDATADIR=\"/usr/share/geany-plugins/git-changebar\" -DPLUGINDOCDIR=\"/usr/share
/doc/geany-plugins-1.36-r1/git-changebar\" -DPLUGINLIBDIR=\"/usr/lib64/geany-plugins/git-changebar\" -DPLUGIN=\"git-changebar\" -DGTK -I/usr/include/geany -I/usr/include/geany/tagmanager -I/usr/include/geany/scintilla 
-I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freet
ype2 -I/usr/include/uuid -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1
.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/i
nclude -I/usr/lib64/libffi/include -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/uuid -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/harfbuzz 
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib6
4/dbus-1.0/include -pthread -Iinclude -march=native -O2 -pipe -flto -ftree-vectorize -ftree-loop-distribution -fvect-cost-model=cheap -c gcb-plugin.c  -fPIC -DPIC -o .libs/git_changebar_la-gcb-plugin.o
In file included from /usr/include/git2.h:69,
                 from gcb-plugin.c:29:
gcb-plugin.c:35:38: error: token ""0.99"" is not valid in preprocessor expressions
   35 | #if ! defined (LIBGIT2_SOVERSION) || LIBGIT2_SOVERSION < 22
      |                                      ^~~~~~~~~~~~~~~~~
gcb-plugin.c:39:38: error: token ""0.99"" is not valid in preprocessor expressions
   39 | #if ! defined (LIBGIT2_SOVERSION) || LIBGIT2_SOVERSION < 23
      |                                      ^~~~~~~~~~~~~~~~~
gcb-plugin.c:48:38: error: token ""0.99"" is not valid in preprocessor expressions
   48 | #if ! defined (LIBGIT2_SOVERSION) || LIBGIT2_SOVERSION < 28
      |                                      ^~~~~~~~~~~~~~~~~
gcb-plugin.c: In function ‘on_plugin_configure_response’:
gcb-plugin.c:1606:7: warning: ‘gtk_color_button_get_color’ is deprecated: Use 'gtk_color_chooser_get_rgba' instead [-Wdeprecated-declarations]
 1606 |       gtk_color_button_get_color (GTK_COLOR_BUTTON (cw->added_color_button),
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:74,
                 from gcb-plugin.c:27:
/usr/include/gtk-3.0/gtk/gtkcolorbutton.h:92:12: note: declared here
   92 | void       gtk_color_button_get_color      (GtkColorButton *button,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
gcb-plugin.c:1609:7: warning: ‘gtk_color_button_get_color’ is deprecated: Use 'gtk_color_chooser_get_rgba' instead [-Wdeprecated-declarations]
 1609 |       gtk_color_button_get_color (GTK_COLOR_BUTTON (cw->changed_color_button),
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:74,
                 from gcb-plugin.c:27:
/usr/include/gtk-3.0/gtk/gtkcolorbutton.h:92:12: note: declared here
   92 | void       gtk_color_button_get_color      (GtkColorButton *button,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
gcb-plugin.c:1612:7: warning: ‘gtk_color_button_get_color’ is deprecated: Use 'gtk_color_chooser_get_rgba' instead [-Wdeprecated-declarations]
 1612 |       gtk_color_button_get_color (GTK_COLOR_BUTTON (cw->removed_color_button),
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:74,
                 from gcb-plugin.c:27:
/usr/include/gtk-3.0/gtk/gtkcolorbutton.h:92:12: note: declared here
   92 | void       gtk_color_button_get_color      (GtkColorButton *button,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
gcb-plugin.c: In function ‘plugin_configure’:
gcb-plugin.c:1680:5: warning: ‘gtk_color_button_set_color’ is deprecated: Use 'gtk_color_chooser_set_rgba' instead [-Wdeprecated-declarations]
 1680 |     gtk_color_button_set_color (GTK_COLOR_BUTTON (cw->added_color_button),
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:74,
                 from gcb-plugin.c:27:
/usr/include/gtk-3.0/gtk/gtkcolorbutton.h:89:12: note: declared here
   89 | void       gtk_color_button_set_color      (GtkColorButton *button,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
gcb-plugin.c:1683:5: warning: ‘gtk_color_button_set_color’ is deprecated: Use 'gtk_color_chooser_set_rgba' instead [-Wdeprecated-declarations]
 1683 |     gtk_color_button_set_color (GTK_COLOR_BUTTON (cw->changed_color_button),
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:74,
                 from gcb-plugin.c:27:
/usr/include/gtk-3.0/gtk/gtkcolorbutton.h:89:12: note: declared here
   89 | void       gtk_color_button_set_color      (GtkColorButton *button,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
gcb-plugin.c:1686:5: warning: ‘gtk_color_button_set_color’ is deprecated: Use 'gtk_color_chooser_set_rgba' instead [-Wdeprecated-declarations]
 1686 |     gtk_color_button_set_color (GTK_COLOR_BUTTON (cw->removed_color_button),
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtk.h:74,
                 from gcb-plugin.c:27:
/usr/include/gtk-3.0/gtk/gtkcolorbutton.h:89:12: note: declared here
   89 | void       gtk_color_button_set_color      (GtkColorButton *button,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:657: git_changebar_la-gcb-plugin.lo] Error 1
make[3]: Leaving directory '/var/tmp/portage/dev-util/geany-plugins-1.36-r1/work/geany-plugins-1.36/git-changebar/src'
make[2]: *** [Makefile:587: all-recursive] Error 1
make[2]: Leaving directory '/var/tmp/portage/dev-util/geany-plugins-1.36-r1/work/geany-plugins-1.36/git-changebar'
make[1]: *** [Makefile:633: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/dev-util/geany-plugins-1.36-r1/work/geany-plugins-1.36'
make: *** [Makefile:565: all] Error 2
Comment 1 Chris Mayo 2020-03-04 19:54:03 UTC
Fortunately there is already an upstream commit for this:

https://github.com/geany/geany-plugins/commit/9497d829e1b207eb83575dc6f617feecfb89bc16

Seems to work OK with dev-libs/libgit2-0.28.4.

Any testing with dev-libs/libgit2-0.99.0-r1 would be welcome.

I've created an updated ebuild at the linked PR.
Comment 2 Hanspeter Spalinger 2020-03-10 07:23:17 UTC
(In reply to Chris Mayo from comment #1)
> Fortunately there is already an upstream commit for this:
> 
> https://github.com/geany/geany-plugins/commit/
> 9497d829e1b207eb83575dc6f617feecfb89bc16
> 
> Seems to work OK with dev-libs/libgit2-0.28.4.
> 
> Any testing with dev-libs/libgit2-0.99.0-r1 would be welcome.
> 
> I've created an updated ebuild at the linked PR.

Works for me with libgit2-0.99.0-r1
Comment 3 Steve Arnold archtester gentoo-dev 2020-03-13 20:25:13 UTC
Thanks, patch looks good here too.
Comment 4 Larry the Git Cow gentoo-dev 2020-04-10 14:12:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2adf746a17dc26dcaae744ed5ea957632fbf12c8

commit 2adf746a17dc26dcaae744ed5ea957632fbf12c8
Author:     Chris Mayo <aklhfex@gmail.com>
AuthorDate: 2020-03-08 19:41:19 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-04-10 14:12:12 +0000

    dev-util/geany-plugins: make libgit2-0.99 compatible
    
    Closes: https://bugs.gentoo.org/711550
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Chris Mayo <aklhfex@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/14837
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/geany-plugins-1.36-libgit2-0.99.patch    | 55 ++++++++++++++++++++++
 .../geany-plugins/geany-plugins-1.36-r1.ebuild     |  2 +
 2 files changed, 57 insertions(+)
Comment 5 Andreas Sturmlechner gentoo-dev 2020-04-10 14:13:47 UTC
*** Bug 713410 has been marked as a duplicate of this bug. ***