Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 711442 - sys-boot/grub: remove unnecessary dependency on app-emulation/xen-tools
Summary: sys-boot/grub: remove unnecessary dependency on app-emulation/xen-tools
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-03-03 17:39 UTC by jonas.licht
Modified: 2020-03-04 22:53 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jonas.licht 2020-03-03 17:39:16 UTC
The dependency on app-emulation/xen-tools should not needed anymore.

Reproducible: Always
Comment 1 Mike Gilbert gentoo-dev 2020-03-03 17:59:47 UTC
What changed?
Comment 2 jonas.licht 2020-03-03 21:52:38 UTC
The xen headers were imported in the grub project directly.
Comment 3 Peter Große 2020-03-04 20:17:10 UTC
Back in 2014 when you added support for xen to the 2.02 beta2 ebuild [1], the Xen headers required to build weren't yet part of the grub source, therefore the dependency was required.

With Grub 2.02 beta3, the headers were actually included [3].

I just build-tested grub-2.04 with GRUB_PLATFORMS="xen" without having xen-tools installed and it creates the same binaries as on our Xen machines.

So technically there is nothing new, the "change" happened almost 5 years ago. ;)

[1] https://github.com/gentoo/gentoo-gitmig-20150809-draft/commit/7fe9763f7d29ff3641a5cad9007d571350cadcbd
[2] http://git.savannah.gnu.org/cgit/grub.git/commit/?id=e07badcc31babb24ace4f96444bc484502427d3a
Comment 4 Larry the Git Cow gentoo-dev 2020-03-04 22:52:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f10d6dc7b6d6eec582732c11b9ddeab8468da6b8

commit f10d6dc7b6d6eec582732c11b9ddeab8468da6b8
Author:     Jonas Licht <jonas.licht@fem.tu-ilmenau.de>
AuthorDate: 2020-03-03 17:40:51 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-03-04 22:52:48 +0000

    sys-boot/grub: remove dependency on xen-tools
    
    Bug: https://bugs.gentoo.org/711442
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Jonas Licht <jonas.licht@fem.tu-ilmenau.de>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/14829

 sys-boot/grub/grub-2.02-r4.ebuild            | 2 --
 sys-boot/grub/grub-2.04-r1.ebuild            | 3 ---
 sys-boot/grub/grub-2.05_alpha20200110.ebuild | 3 ---
 sys-boot/grub/grub-2.05_alpha20200228.ebuild | 3 ---
 sys-boot/grub/grub-9999.ebuild               | 3 ---
 5 files changed, 14 deletions(-)