Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 711286 - Eclass Reference: eclass list is one big soup in text browsers
Summary: Eclass Reference: eclass list is one big soup in text browsers
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Devmanual Team
URL: https://devmanual.gentoo.org/eclass-r...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-02 07:13 UTC by Michał Górny
Modified: 2020-03-03 08:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
screenshot (eclassref.png,150.39 KB, image/png)
2020-03-02 07:13 UTC, Michał Górny
Details
listgroup fix (webview) (listgroup-fix_webview.png,14.86 KB, image/png)
2020-03-02 15:53 UTC, Max Magorsch (RETIRED)
Details
listgroup fix (textview) (listgroup-fix_textview.png,3.54 KB, image/png)
2020-03-02 15:53 UTC, Max Magorsch (RETIRED)
Details
fixed devmanual (textview) (devmanual_fixed.png,19.13 KB, image/png)
2020-03-02 15:54 UTC, Max Magorsch (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-02 07:13:27 UTC
Created attachment 616762 [details]
screenshot

It seems that the list in 'Eclass Reference' embraces the horrible idea of using an inline element to build a list and turning it to block element via CSS.  As a result, the eclass list is a wall-of-text soup in text browsers:
Comment 1 Ulrich Müller gentoo-dev 2020-03-02 08:04:46 UTC
This is a bug (or feature?) of Bootstrap list groups:
https://getbootstrap.com/docs/3.3/components/#list-group

You'll see the same rendering on other sites, e.g., https://infra-status.gentoo.org/. I don't think there's anything we can do about it (other than changing the list into a regular <ul>).

CCing www: Should this be reported to Bootstrap upstream?
Comment 2 Max Magorsch (RETIRED) Gentoo Infrastructure gentoo-dev 2020-03-02 15:53:26 UTC
Created attachment 616774 [details]
listgroup fix (webview)
Comment 3 Max Magorsch (RETIRED) Gentoo Infrastructure gentoo-dev 2020-03-02 15:53:48 UTC
Created attachment 616776 [details]
listgroup fix (textview)
Comment 4 Max Magorsch (RETIRED) Gentoo Infrastructure gentoo-dev 2020-03-02 15:54:57 UTC
Created attachment 616778 [details]
fixed devmanual (textview)
Comment 5 Max Magorsch (RETIRED) Gentoo Infrastructure gentoo-dev 2020-03-02 15:57:03 UTC
We might indeed report this to upstream. 

However, so far we might fix this as suggested in https://github.com/gentoo/devmanual/pull/162 by changing the list into a regular ul as suggested by ulm and add individual parents around each link. 

This way we would get the same behaviour and appearance as before while fixing the issue.

I've attached some screenshots.
Comment 6 Ulrich Müller gentoo-dev 2020-03-02 17:13:32 UTC
Why don't we get rid of that list-group altogether? It is used nowhere else in the devmanual, and its items need about twice as much vertical space than the items in a regular <ul> list. Which means that one must scroll by twice as much, in order to reach an item at the bottom of the list.
Comment 7 Larry the Git Cow gentoo-dev 2020-03-03 08:30:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=322da3e34dc68d83b8d5cfd4431c8d9ebb092add

commit 322da3e34dc68d83b8d5cfd4431c8d9ebb092add
Author:     Max Magorsch <arzano@gentoo.org>
AuthorDate: 2020-03-02 15:43:22 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2020-03-03 08:27:47 +0000

    Fix list-groups in text browsers
    
    Closes: https://bugs.gentoo.org/711286
    Signed-off-by: Max Magorsch <arzano@gentoo.org>
    [Removed extra newline before </li>.]
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 devbook.xsl   | 13 +++++++------
 devmanual.css | 13 +++++++++++++
 2 files changed, 20 insertions(+), 6 deletions(-)