Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 711172 - media-tv/mythtv-30.0_p20190808-r2: -python flag not building + fix
Summary: media-tv/mythtv-30.0_p20190808-r2: -python flag not building + fix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Wilson M. Michaels
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-03-01 15:12 UTC by Jesper Saxtorph
Modified: 2020-03-03 14:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesper Saxtorph 2020-03-01 15:12:27 UTC
Trying to emerge the mythtv ebuild with -python will always fail.
The reason is that the ebuild is still calling python_optimize and python_fix_shebang. I made it compile by making those two calls depend on the python use flag. My mythtv backend is not up running at the moment, so I have not tested if it is actually working.

Reproducible: Always

Steps to Reproduce:
1. USE="-python" emerge mythtv
Actual Results:  
The ebuild will not finish because "EPYTHON unset" during call to python_optimize.


Diff to working ebuild:
--- /usr/portage/media-tv/mythtv/mythtv-30.0_p20190808-r2.ebuild        2020-02-21 07:39:37.000000000 +0100
+++ mythtv-30.0_p20190808-r2.ebuild     2020-03-01 13:00:49.776311064 +0100
@@ -357,7 +357,7 @@
 
 src_install() {
        emake STRIP="true" INSTALL_ROOT="${D}" install
-       python_optimize  # does all packages by default
+       use python && python_optimize  # does all packages by default
        dodoc AUTHORS UPGRADING README
        readme.gentoo_create_doc
 
@@ -408,7 +408,7 @@
                -exec chmod a+x {} \; || die "Failed to make python file $(basename ${file}) executable"
 
        # Ensure that Python scripts are executed by Python 2
-       python_fix_shebang "${ED}/usr/share/mythtv"
+       use python && python_fix_shebang "${ED}/usr/share/mythtv"
 
        # Make shell & perl scripts executable
        find "${ED}" -type f \( -name '*.sh' -o -name '*.pl' \) -exec chmod a+x {} \; || die "Failed to make script executable"
Comment 1 Larry the Git Cow gentoo-dev 2020-03-03 14:54:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5b50c406032fba9eec57eaac78b814774671dd5

commit b5b50c406032fba9eec57eaac78b814774671dd5
Author:     Wilson Michaels <thebitpit@earthlink.net>
AuthorDate: 2020-03-02 18:57:57 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-03-03 14:53:42 +0000

    media-tv/mythtv: Fix fail when USE = -python
    
    Closes: https://bugs.gentoo.org/711172
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Wilson Michaels <thebitpit@earthlink.net>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-tv/mythtv/mythtv-29.1-r2.ebuild           | 3 ++-
 media-tv/mythtv/mythtv-30.0_p20190808-r2.ebuild | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)