Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710982 - mail-filter/amavisd-new-2.12.0-r2 latest version dep on dev-perl/Archive-Zip was removed, without it it does not work
Summary: mail-filter/amavisd-new-2.12.0-r2 latest version dep on dev-perl/Archive-Zip ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major
Assignee: Ralph Seichter
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-27 18:27 UTC by Tetja Rediske
Modified: 2020-02-28 03:58 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tetja Rediske 2020-02-27 18:27:38 UTC
Hi,

after today update to amavisd-new/amavisd-new-2.12.0-r2 amavisd-new stopped working and killing my Mailserver with it. 

It was because of dev-perl/Archive-Zip missing.

Seems like Commit https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe4d2530ec228792fac96fd3c04599f181056dfd introduced that.

Please readd the dep.

Reproducible: Always
Comment 1 Ralph Seichter 2020-02-27 19:43:11 UTC
I was asked to remove the dev-perl/Archive-Zip by the reviewer [1], so that is what I did. I will only put it back in if given the OK.

[1] https://github.com/gentoo/gentoo/pull/14656#discussion_r380494273
Comment 2 Ralph Seichter 2020-02-27 19:58:23 UTC
(In reply to Tetja Rediske from comment #0)

> after today update to amavisd-new/amavisd-new-2.12.0-r2 amavisd-new
> stopped working and killing my Mailserver with it.
I missed mentioning this earlier: A reduced dependency set does not mean existing packages will be removed by executing "emerge -u". It definitely did not happen on our mail servers.
Comment 3 Tetja Rediske 2020-02-27 20:09:26 UTC
Sure, a -u won't, but a "emerge -c" will.

Since I had no other package using it, it happily removed it.
Comment 4 Tetja Rediske 2020-02-27 20:15:22 UTC
Sure, I should have paid better attention.

In the Discussion above they are removed because of "always satisfied", which make no sense to me. Why would even clamav always be satisfied? (next thing i will check on my machine i guess)

Regarding to the dev-perl/Archive-Zip nothing else is pulling it in and it does not look optional to me.

Even if all of those are optional, maybe a emerge message would be a good way to tell, especially after that change took place.
Comment 5 Ralph Seichter 2020-02-27 20:19:34 UTC
(In reply to Tetja Rediske from comment #3)

> Sure, a -u won't, but a "emerge -c" will.
Well, the emerge manual page clearly states:

  WARNING: Inexperienced users are advised to use --pretend
  or --ask with this option in order to see a preview of which
  packages will be uninstalled. Always study the list of
  packages to be cleaned for any obvious mistakes.

This is not meant to troll or disrespect you. emerge -c is always a step to be taken very carefully.

So the actual issue is that Archive-Zip has no reverse dependencies anymore:

  $ equery depends dev-perl/Archive-Zip
   * These packages depend on dev-perl/Archive-Zip:

Juippis, can you please chime in on how you want this handled?
Comment 6 Thomas Deutschmann (RETIRED) gentoo-dev 2020-02-27 20:30:09 UTC
Looks like there was a misunderstanding. Let's wait for juippis response. I guess he just meant ">=", not the complete dep.
Comment 7 Larry the Git Cow gentoo-dev 2020-02-28 03:52:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a335f0bf2b81890fc4331c17f88aad03e5ba831

commit 7a335f0bf2b81890fc4331c17f88aad03e5ba831
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2020-02-28 03:52:04 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-02-28 03:52:04 +0000

    mail-filter/amavisd-new: add missing dep for dev-perl/Archive-Zip
    
    Closes: https://bugs.gentoo.org/710982
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../{amavisd-new-2.12.0-r2.ebuild => amavisd-new-2.12.0-r3.ebuild}       | 1 +
 1 file changed, 1 insertion(+)
Comment 8 Joonas Niilola gentoo-dev 2020-02-28 03:58:08 UTC
(In reply to Thomas Deutschmann from comment #6)
> Looks like there was a misunderstanding. Let's wait for juippis response. I
> guess he just meant ">=", not the complete dep.

Indeed that's how we prefer it to improve readability and in some ways portability to ebuilds. 

So "virtual/perl-IO-Compress" instead of ">=virtual/perl-IO-Compress-1.35" whenever <1.35 hasn't existed in tree for a while. This also flags a CI note after a while in verbose mode.

I think my failure in here was however building the PR before waiting an update to it, instead of waiting an udpate and THEN building it. I should've caught that because I use an empty stage3 image to test these.

Seems like candrews saved most part of it, 
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=45ffd7c8407d4f8c51b513947fd178dd70cec9cf

Should be done now, thanks!