Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710918 - Devmanual: Makefile %.html rule misses previous and next document as prerequisites
Summary: Devmanual: Makefile %.html rule misses previous and next document as prerequi...
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Devmanual Team
URL: https://devmanual.gentoo.org/ebuild-w...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-26 21:31 UTC by Ulrich Müller
Modified: 2020-03-02 10:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2020-02-26 21:31:06 UTC
Recently ebuild-writing/functions/src_unpack/cvs-sources and svn-sources have been combined into one section vcs-sources. However, the page following it (rpm-sources) still has a backlink pointing to svn-sources, see URL.

The reason is that the current rule in the Makefile is incomplete:

%.html: $$(dir $$@)text.xml devbook.xsl xsl/*.xsl $$(subst text.xml,index.html,$$(wildcard $$(dir $$@)*/text.xml))

This depends on all children (and indirectly on all descendants), but it doesn't depend on the previous and next documents.
Comment 1 Larry the Git Cow gentoo-dev 2020-03-02 10:23:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=9b663cce9ed88ec5b86cfde8d050017d23894798

commit 9b663cce9ed88ec5b86cfde8d050017d23894798
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2020-02-26 20:21:54 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2020-03-01 21:40:46 +0000

    Makefile, depend.xsl: Use XSLT to generate the list of dependencies.
    
    Each HTML file must depend on its XML file with all its descendants
    (for the contents tree), all its ancestors (for breadcrumbs), and the
    previous and next documents (for backward and forward links).
    
    Trying to generate the list of dependencies with make seems hopeless
    (especially, how would one determine the previous and next documents?).
    OTOH, the necessary templates already exist in devbook.xsl. Therefore,
    add a simple depend.xsl on top of it, which outputs a dependency list
    as plain text.
    
    Closes: https://bugs.gentoo.org/710918
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 .gitignore |  1 +
 Makefile   | 21 +++++++++++++--------
 depend.xsl | 33 +++++++++++++++++++++++++++++++++
 3 files changed, 47 insertions(+), 8 deletions(-)