As per summary: /var/tmp/portage/kde-misc/basket-2.49b/work/basket-2.49b/src/application.cpp: In constructor ‘Application::Application(int&, char**)’: /var/tmp/portage/kde-misc/basket-2.49b/work/basket-2.49b/src/application.cpp:62:13: error: ‘git_threads_init’ was not declared in this scope; did you mean ‘git_rebase_init’? 62 | git_threads_init(); | ^~~~~~~~~~~~~~~~ | git_rebase_init /var/tmp/portage/kde-misc/basket-2.49b/work/basket-2.49b/src/application.cpp: In destructor ‘virtual Application::~Application()’: /var/tmp/portage/kde-misc/basket-2.49b/work/basket-2.49b/src/application.cpp:73:13: error: ‘git_threads_shutdown’ was not declared in this scope 73 | git_threads_shutdown(); | ^~~~~~~~~~~~~~~~~~~~
Created attachment 615930 [details] emerge --info
Created attachment 615934 [details] build.log
I've opened an issue upstream https://github.com/basket-notepads/basket/issues/45 as this looks like it's just under-maintained. It also looks like a trivial fix, which I might take a swing at if I get chance later tonight.
Created attachment 615936 [details, diff] Proposed fix Problem is actually around the libgit2 version detection and a presumed change in LIBGIT2_SOVERSION to be a char *, not a number. Patch changes the check to be against LIBGIT2_VER_MINOR (99 >= 22)
Could you please submit your fix as a PR upstream?
Done! https://github.com/basket-notepads/basket/pull/46
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34f8f2b233bcf437aa08a2d48838645b50e77d16 commit 34f8f2b233bcf437aa08a2d48838645b50e77d16 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2020-03-01 22:01:05 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2020-03-01 22:02:11 +0000 kde-misc/basket: Fix build against >=dev-libs/libgit2-0.99 Thanks-to: Dan Goodliffe <gentoo@randomdan.homeip.net> Closes: https://bugs.gentoo.org/710832 Package-Manager: Portage-2.3.90, Repoman-2.3.20 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> kde-misc/basket/basket-2.49b.ebuild | 5 +++- .../files/basket-2.49b-libgit2-0.99-compat.patch | 32 ++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-)
Thanks again for your contribution. This is just to notify you that basket repository was recently moved (back) to kde.org and libgit2-0.99 support was fixed over there, in a slightly different way: https://cgit.kde.org/basket.git/commit/?id=090ac46912025f94aca710355e51a8154df36a56
