Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710688 - devaway: use ISO date
Summary: devaway: use ISO date
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Developer account issues (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Infrastructure
URL: https://www.gentoo.org/inside-gentoo/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-24 18:50 UTC by Jonas Stein
Modified: 2021-08-26 13:58 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2020-02-24 18:50:12 UTC
all messages should use iso date for the automatic time stamp and the human written text.

First we should focus on the part behind the @.

These examples show the current situation:
"afk for a while - 2019.09.23 @ 2020/01/26 08:51Z"

"Out of the country til 2/7. Emergencies, feel free to touch packages within @ 2020/01/16 00:01Z"



Reproducible: Always
Comment 2 Alec Warner (RETIRED) archtester gentoo-dev Security 2021-08-25 23:52:24 UTC
If you submit a patch I'll merge it.

-A
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-08-26 08:08:43 UTC
For a start, we'd have to find where devaway.xml is generated.  It would probably also make sense to add the date as an attribute, rather than putting it into <reason/>.
Comment 4 Larry the Git Cow gentoo-dev 2021-08-26 09:17:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/sites/www.git/commit/?id=50e92f74dbac007c5656f9eef2a34be4f428dd08

commit 50e92f74dbac007c5656f9eef2a34be4f428dd08
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-08-26 09:16:17 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-08-26 09:17:16 +0000

    Explicitly format devaway dates in ISO 8601-ish
    
    Closes: https://bugs.gentoo.org/710688
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 _plugins/devaway.rb                                  | 10 ++++++----
 inside-gentoo/developers/index.html                  |  2 +-
 inside-gentoo/developers/unavailable-developers.html |  2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-08-26 09:19:01 UTC
I think this should cover your concerns.  We've been parsing the dates anyway, so I've just stripped them from reason and formatted explicitly.

The next steps would be to:

1. Add date="" field to the XML.

2. Switch WWW to prefer using the date="" field over parsing date from reason.

3. Remove date from reason in the XML.