Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710640 - dev-libs/beignet still requires LLVM 7
Summary: dev-libs/beignet still requires LLVM 7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2020-03-25
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2020-02-24 09:17 UTC by Michał Górny
Modified: 2020-03-25 13:36 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Emerge log, tmux dump (beignet-build.log,296.45 KB, text/x-log)
2020-03-15 09:36 UTC, Denis Tolstov
Details
emerge --info (emerge-info.log,6.37 KB, text/x-log)
2020-03-15 10:08 UTC, Denis Tolstov
Details
sudo env FEATURES=test emerge -v --digest =beignet-1.3.2-r4 (beignet-1.3.2-r4:20200315-095537.log,299.40 KB, text/x-log)
2020-03-15 10:11 UTC, Denis Tolstov
Details
patch_llvm8 from FreeBSD slightly adjusted (--- a/, +++ b/) (beignet-1.3.2_llvm8.patch,1.78 KB, patch)
2020-03-15 10:12 UTC, Denis Tolstov
Details | Diff
patch_llvm9 from FreeBSD (beignet-1.3.2_llvm9.patch,11.20 KB, patch)
2020-03-15 10:13 UTC, Denis Tolstov
Details | Diff
[patch 3/3] from Rebecca Palmer (beignet-1.3.2_llvm8-rotates.patch,3.01 KB, patch)
2020-03-15 10:14 UTC, Denis Tolstov
Details | Diff
clinfo (clinfo.log,7.53 KB, text/x-log)
2020-03-15 10:22 UTC, Denis Tolstov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-02-24 09:17:15 UTC
With LLVM 9 being stable, and LLVM 10 going to be released soon, it's time to start thinking about LLVM 7 cleanup.  Please look into adding a version that works with LLVM 8 or 9.
Comment 1 Larry the Git Cow gentoo-dev 2020-02-24 19:11:12 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6fffb5ba5e48e4f0c25309d52090633cf7540695

commit 6fffb5ba5e48e4f0c25309d52090633cf7540695
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-02-24 19:09:04 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-02-24 19:10:31 +0000

    profiles: mask dev-libs/beignet for removal
    
    Bug: https://bugs.gentoo.org/710640
    
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 profiles/package.mask | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Comment 2 Denis Tolstov 2020-03-15 09:36:29 UTC
Created attachment 619652 [details]
Emerge log, tmux dump
Comment 3 Denis Tolstov 2020-03-15 09:38:21 UTC
According to Rebecca Palmer on [3] this is easily fixable with minor patching. So I downloaded it from [3, llvm8_rotates] and patch-llvm8 from [1, llvm8], throwed them into /etc/portage/patches/dev-libs/beignet; copied the ebuild as beignet-1.3.2-r4.ebuild and bumped LLVM_MAX_SLOT to 8, COMMON to <sys-devel/clang-9.0.0.

The next emerge -avu --digest =beignet-1.3.2-r4.ebuild completed successfully in usual 10 minutes.

Please consider either testing the patches with at least llvm-8.0.1 yourself, or provide clear instructions for me (env FEATURES=test emerge -av beignet?) on doing that. I don't have a local overlay yet.

URLs:
[1] https://svnweb.freebsd.org/ports/head/lang/beignet/files/patch-llvm8?revision=505425&view=markup
[2] https://svnweb.freebsd.org/ports/head/lang/beignet/files/patch-llvm9?revision=512439&view=markup
[3] https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1720943.html 
[4] https://salsa.debian.org/opencl-team/beignet/-/commit/36b727351615ed68cc5f7c9c564b009bf21218fa but that's [1] and [2] in gitlab
[5] https://salsa.debian.org/opencl-team/beignet/-/commit/6d4c1d77020941b602992987ba4939600056b8f5 and that's [3] in gitlab
Comment 4 Denis Tolstov 2020-03-15 10:08:22 UTC
Created attachment 619656 [details]
emerge --info
Comment 5 Denis Tolstov 2020-03-15 10:11:02 UTC
Created attachment 619658 [details]
sudo env FEATURES=test emerge -v --digest =beignet-1.3.2-r4
Comment 6 Denis Tolstov 2020-03-15 10:12:57 UTC
Created attachment 619660 [details, diff]
patch_llvm8 from FreeBSD slightly adjusted (--- a/, +++ b/)
Comment 7 Denis Tolstov 2020-03-15 10:13:44 UTC
Created attachment 619662 [details, diff]
patch_llvm9 from FreeBSD

slightly adjusted (--- a/, +++ b/)
Comment 8 Denis Tolstov 2020-03-15 10:14:41 UTC
Created attachment 619692 [details, diff]
[patch 3/3] from Rebecca Palmer
Comment 9 Denis Tolstov 2020-03-15 10:22:01 UTC
Created attachment 619694 [details]
clinfo

This clinfo-2.2.18.04.06 was built with llvm-7.1.0 against beignet-1.3.2-r3.
Comment 10 Larry the Git Cow gentoo-dev 2020-03-25 13:36:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=710a434a1aa581263d609d75b0a363be4e89579a

commit 710a434a1aa581263d609d75b0a363be4e89579a
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-03-25 13:31:16 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-03-25 13:35:29 +0000

    dev-libs/beignet: remove last-rited package
    
    Closes: https://bugs.gentoo.org/710640
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 dev-libs/beignet/Manifest                          |   1 -
 dev-libs/beignet/beignet-1.3.2-r3.ebuild           | 104 -----------------
 .../files/beignet-1.2.0_no-hardcoded-cflags.patch  |  12 --
 .../beignet-1.3.1-oclicd_no_upstream_icdfile.patch |  14 ---
 .../beignet-1.3.2_cmake-llvm-config-multilib.patch |  17 ---
 ...eignet-1.3.2_disable-doNegAddOptimization.patch |  66 -----------
 dev-libs/beignet/files/beignet-1.3.2_llvm6.patch   |  27 -----
 dev-libs/beignet/files/beignet-1.3.2_llvm7.patch   | 124 ---------------------
 dev-libs/beignet/files/llvm-terminfo.patch         |  20 ----
 dev-libs/beignet/files/no-debian-multiarch.patch   |  39 -------
 dev-libs/beignet/metadata.xml                      |  14 ---
 11 files changed, 438 deletions(-)