Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710512 - x11-themes/fvwm-crystal-3.6.5 version bump
Summary: x11-themes/fvwm-crystal-3.6.5 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Dominique Michel
URL: https://sourceforge.net/projects/fvwm...
Whiteboard:
Keywords: PullRequest
Depends on: 710616
Blocks:
  Show dependency tree
 
Reported: 2020-02-22 18:20 UTC by Dominique Michel
Modified: 2020-06-18 00:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild (fvwm-crystal-3.6.2.ebuild,2.42 KB, text/plain)
2020-02-22 18:27 UTC, Dominique Michel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dominique Michel 2020-02-22 18:20:43 UTC
The last week, 2 new versions of fvwm-crystal was released. The last one is 3.6.2.

From 3.6.0, fvwm-crystal depend on fvwm-2.6.9 and python3. In the additional supported software, it is also systemd in addition of pm-utils for hibernate/resume support. If both are installed, systemd will be used by crystal.

Reproducible: Always
Comment 1 Dominique Michel 2020-02-22 18:27:26 UTC
Created attachment 615146 [details]
updated ebuild
Comment 2 Jonas Stein gentoo-dev 2020-02-22 19:18:10 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman
* We always try to use the latest EAPI, please bump to EAPI=7
* why inherit eutils?
* please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)
* Please prepare a PR on github. A bot can look for additional mistakes, if you upload a PR via github
Comment 3 Dominique Michel 2020-02-23 17:08:05 UTC
Thank you four the answer.

repoman tell me to follow the GLEP 81 instead of using the user eclass. This imply to add acct-group/fvwm-crystal into the tree.
https://www.gentoo.org/glep/glep-0081.html

Also, I think it would be better to use python-single-r1 instead of python-r1. fvwm-crystal should work with python-3.*, but it need only one of them. python-r1 just add unnecessary complexity.
https://dev.gentoo.org/~mgorny/python-guide/single.html
Comment 4 Dominique Michel 2020-02-23 20:58:32 UTC
I made this bug repport for acct-group/fvwm-crystal:
https://bugs.gentoo.org/710616
Comment 5 Larry the Git Cow gentoo-dev 2020-06-18 00:48:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d7e3833a65c0b5df2137687a16f2c078e93abd3

commit 0d7e3833a65c0b5df2137687a16f2c078e93abd3
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2020-06-10 02:17:32 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2020-06-18 00:46:48 +0000

    x11-themes/fvwm-crystal: Version bump, migrate to GLEP 81.
    
    This switches to the latest fvwm-crystal, which supports python3,
    and switches to acct-group/fvwm-crystal for group creation.
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/710512
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Closes: https://github.com/gentoo/gentoo/pull/16159
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 x11-themes/fvwm-crystal/Manifest                  |  1 +
 x11-themes/fvwm-crystal/fvwm-crystal-3.6.5.ebuild | 82 +++++++++++++++++++++++
 2 files changed, 83 insertions(+)