Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710394 - sys-apps/coreutils-8.31 should not depend on dev-python/pyinotify
Summary: sys-apps/coreutils-8.31 should not depend on dev-python/pyinotify
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-02-21 12:06 UTC by Jason Chan
Modified: 2020-03-05 15:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (coreutils-8.31-r2:20200221-120127_nocolor.log,739.25 KB, text/plain)
2020-02-21 12:08 UTC, Jason Chan
Details
coreutils ebuild diff (coreutils-8.31-remove-pyinotify-from-ebuild.patch,879 bytes, patch)
2020-02-21 12:10 UTC, Jason Chan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Chan 2020-02-21 12:06:42 UTC
pyinotify has no official support past Python 3.4. The one test in question that requires it allows skipping the test if it isn't installed.

${S}/tests/du/move-dir-while-traversing.sh:
 23 # We use a python-inotify script, so...
 24 python -m pyinotify -h > /dev/null \
 25   || skip_ 'python inotify package not installed'

Passed test, see build.log

Reproducible: Always
Comment 1 Jason Chan 2020-02-21 12:08:47 UTC
Created attachment 614816 [details]
build.log

FEATURES="-sandbox -usersandbox -pidsandbox"

============================================================================
Testsuite summary for GNU coreutils 8.31
============================================================================
# TOTAL: 332
# PASS:  301
# SKIP:  31
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Comment 2 Jason Chan 2020-02-21 12:10:13 UTC
Created attachment 614818 [details, diff]
coreutils ebuild diff

Added 3.8 to PYTHON_COMPAT, changed EAPI to 7.
Comment 3 Larry the Git Cow gentoo-dev 2020-03-05 15:26:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2180ffa48566c9ba6d6a5018e487e79fede3e638

commit 2180ffa48566c9ba6d6a5018e487e79fede3e638
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2020-03-05 15:25:44 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2020-03-05 15:25:44 +0000

    sys-apps/coreutils: Drop dev-python/pyinotify dependency
    
    Thanks-to: Jason Chan <graysonchsi@gmail.com>
    Closes: https://bugs.gentoo.org/710394
    Package-Manager: Portage-2.3.92, Repoman-2.3.20
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-apps/coreutils/coreutils-8.31-r1.ebuild | 5 -----
 sys-apps/coreutils/coreutils-8.32.ebuild    | 7 +------
 2 files changed, 1 insertion(+), 11 deletions(-)