Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710390 - dev-python/css-parser-1.0.4 - license change and python3_8 support
Summary: dev-python/css-parser-1.0.4 - license change and python3_8 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Zac Medico
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-02-21 11:33 UTC by Jason Chan
Modified: 2020-04-26 23:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Chan 2020-02-21 11:33:22 UTC
License: GNU Library or Lesser General Public License (LGPL) (LGPL 2.1 or later)
I tried adding tests to the ebuild since they're clearly there but the files magically disappear when I unzip the snapshot, PyPi source, or the tagged release.

---

--- css-parser-1.0.4-r1.ebuild
+++ css-parser-1.0.4-r2.ebuild
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
-PYTHON_COMPAT=( python{2_7,3_{6,7}} )
+PYTHON_COMPAT=( python{2_7,3_{6,7,8}} )
 
 inherit distutils-r1
 
@@ -10,8 +10,19 @@ DESCRIPTION="A CSS Cascading Style Sheet
 HOMEPAGE="https://pypi.org/project/css-parser/"
 SRC_URI="mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz"
 
-LICENSE="LGPL-3"
+LICENSE="LGPL-2.1+"
 SLOT="0"
 KEYWORDS="amd64 ~arm x86"
+IUSE="test"
 
-BDEPEND="dev-python/setuptools[${PYTHON_USEDEP}]"
+RESTRICT="test" # The test files disappear when I unzip the tarball
+
+BDEPEND="
+       dev-python/setuptools[${PYTHON_USEDEP}]
+       test? ( dev-python/unittest2[${PYTHON_USEDEP}] )
+       "
+
+python_test() {
+        unit2 -v || die
+}
+distutils_enable_tests unittest
 

Reproducible: Always
Comment 1 Andreas Sturmlechner gentoo-dev 2020-04-26 17:07:38 UTC
ping, proxied maintainer depends on this to add py38 to app-text/sigil.
Comment 2 Larry the Git Cow gentoo-dev 2020-04-26 23:19:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=315d95092d7a32cfe600ef8c8632e89950c8f4aa

commit 315d95092d7a32cfe600ef8c8632e89950c8f4aa
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-04-26 23:17:47 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-04-26 23:19:12 +0000

    dev-python/css-parser: Update PYTHON_COMPAT
    
    Bug: https://bugs.gentoo.org/710390
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 dev-python/css-parser/css-parser-1.0.4-r1.ebuild | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Comment 3 Zac Medico gentoo-dev 2020-04-26 23:22:07 UTC
(In reply to Jason Chan from comment #0)
> License: GNU Library or Lesser General Public License (LGPL) (LGPL 2.1 or
> later)

If the license has changed, then why does it still have LGPL-3 here?

https://github.com/ebook-utils/css-parser/blob/master/COPYING.LESSER
Comment 4 Zac Medico gentoo-dev 2020-04-26 23:25:03 UTC
Ok, I see the LGPL 2.1 or later here:

https://github.com/ebook-utils/css-parser/blob/v1.0.4/setup.py#L64
Comment 5 Larry the Git Cow gentoo-dev 2020-04-26 23:31:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=555a96973594a8491bc5fb5fb3be1ae25f64da0e

commit 555a96973594a8491bc5fb5fb3be1ae25f64da0e
Author:     Jason Chan <graysonchsi@gmail.com>
AuthorDate: 2020-04-26 23:27:11 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-04-26 23:31:06 +0000

    dev-python/css-parser: update LICENSE to LGPL-2.1+
    
    In setup.py it calls setup(license='LGPL 2.1 or later').
    
    See: https://github.com/ebook-utils/css-parser/blob/v1.0.4/setup.py#L64
    Closes: https://bugs.gentoo.org/710390
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 dev-python/css-parser/css-parser-1.0.4-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)