Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710330 - app-misc/rox-filer-2.11 : fails to build with -fno-common or gcc-10
Summary: app-misc/rox-filer-2.11 : fails to build with -fno-common or gcc-10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: P Purkayastha
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2020-02-20 18:22 UTC by Toralf Förster
Modified: 2020-11-28 17:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.04 KB, text/plain)
2020-02-20 18:22 UTC, Toralf Förster
Details
app-misc:rox-filer-2.11:20200220-071533.log (app-misc:rox-filer-2.11:20200220-071533.log,77.64 KB, text/plain)
2020-02-20 18:22 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,153.22 KB, text/plain)
2020-02-20 18:22 UTC, Toralf Förster
Details
environment (environment,78.36 KB, text/plain)
2020-02-20 18:22 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,14.54 KB, application/x-bzip)
2020-02-20 18:22 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,6.66 KB, application/x-bzip)
2020-02-20 18:22 UTC, Toralf Förster
Details
New rox-filer-2.11-r1.ebuild (rox-filer-2.11-r1.ebuild,2.29 KB, text/plain)
2020-11-17 11:13 UTC, P Purkayastha
Details
Use patch instead of sed command (rox-filer-2.11-APP_DIR-fix.patch,347 bytes, patch)
2020-11-17 11:14 UTC, P Purkayastha
Details | Diff
Fix prestripped files (rox-filer-2.11-fix-prestripped-files.patch,422 bytes, patch)
2020-11-17 11:14 UTC, P Purkayastha
Details | Diff
Fix compilation with gcc-10 (rox-filer-2.11-gcc-10-fix.patch,220 bytes, patch)
2020-11-17 11:15 UTC, P Purkayastha
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-02-20 18:22:27 UTC
xdgmimecache.c:45:2: warning: #warning Building xdgmime without MMAP support. Binary "mime.info" cache files will not be used. [-Wcpp]
   45 | #warning Building xdgmime without MMAP support. Binary "mime.info" cache files will not be used.
      |  ^~~~~~~
x86_64-pc-linux-gnu-gcc -o "ROX-Filer" abox.o action.o appinfo.o appmenu.o bind.o bookmarks.o bulk_rename.o cell_icon.o choices.o collection.o dir.o diritem.o display.o dnd.o dropbox.o filer.o find.o fscache.o gtksavebox.o gui_support.o i18n.o icon.o infobox.o log.o main.o menu.o minibuffer.o modechange.o mount.o options.o panel.o pinboard.o pixmaps.o remote.o run.o sc.o session.o support.o tasklist.o toolbar.o type.o usericons.o view_collection.o view_details.o view_iface.o wrapped.o xml.o xtypes.o xdgmime.o xdgmimeglob.o xdgmimeint.o xdgmimemagic.o xdgmimeparent.o xdgmimealias.o xdgmimecache.o  -Wl,-O1 -Wl,--as-needed `pkg-config  --libs gtk+-2.0 libxml-2.0 | sed 's/-lpangoxft-[^ ]*//'` -lm -ldl  -lX11   -lICE -lSM
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: session.o:(.bss+0x0): multiple definition of `session_auto_respawn'; main.o:(.bss+0x178): first defined here
collect2: error: ld returned 1 exit status

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma_systemd-20200216-164747

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.41.0 *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.14.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm
ghc:
The Glorious Glasgow Haskell Compilation System, version 8.0.2

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Thu, 20 Feb 2020 03:07:36 +0000

emerge -qpvO app-misc/rox-filer
[ebuild  N    ] app-misc/rox-filer-2.11  USE="-test"
Comment 1 Toralf Förster gentoo-dev 2020-02-20 18:22:30 UTC
Created attachment 614678 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-02-20 18:22:32 UTC
Created attachment 614680 [details]
app-misc:rox-filer-2.11:20200220-071533.log
Comment 3 Toralf Förster gentoo-dev 2020-02-20 18:22:36 UTC
Created attachment 614682 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2020-02-20 18:22:39 UTC
Created attachment 614684 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2020-02-20 18:22:41 UTC
Created attachment 614686 [details]
etc.portage.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-02-20 18:22:44 UTC
Created attachment 614688 [details]
logs.tbz2
Comment 7 P Purkayastha 2020-11-17 11:13:15 UTC
Created attachment 671815 [details]
New rox-filer-2.11-r1.ebuild


Patch for rox-filer fixing multiple bugs - bug 745018 , bug 710330  and changed to EAPI 7. I will attach the other patches in ${FILESDIR} in subsequent posts.

--- /usr/portage/app-misc/rox-filer/rox-filer-2.11.ebuild       2019-08-29 21:46:34.476602777 +0800
+++ /usr/local/portage/app-misc/rox-filer/rox-filer-2.11-r1.ebuild      2020-11-17 19:03:55.071253860 +0800
@@ -1,9 +1,9 @@
 # Copyright 1999-2019 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=5
+EAPI=7
 
-inherit desktop epatch virtualx
+inherit desktop virtualx
 
 DESCRIPTION="ROX-Filer a drag and drop spatial file manager"
 HOMEPAGE="http://rox.sourceforge.net/desktop"
@@ -27,12 +27,12 @@
 
 S="${WORKDIR}/${P}"/ROX-Filer/src
 
-src_prepare() {
-       epatch "${FILESDIR}/${P}-in-source-build.patch"
-
-       sed -i -e 's:g_strdup(getenv("APP_DIR")):"/usr/share/rox":' \
-               main.c || die "sed failed"
-}
+PATCHES=(
+       "${FILESDIR}/${P}-in-source-build.patch"
+       "${FILESDIR}/${P}-APP_DIR-fix.patch"
+       "${FILESDIR}/${P}-fix-prestripped-files.patch"
+       "${FILESDIR}/${P}-gcc-10-fix.patch"
+)
 
 src_configure() {
        econf LIBS="-lm -ldl"
Comment 8 P Purkayastha 2020-11-17 11:14:00 UTC
Created attachment 671818 [details, diff]
Use patch instead of sed command

Use patch instead of sed command in ebuild.
Comment 9 P Purkayastha 2020-11-17 11:14:48 UTC
Created attachment 671821 [details, diff]
Fix prestripped files

Patch to stop pre-stripping binary
Comment 10 P Purkayastha 2020-11-17 11:15:22 UTC
Created attachment 671824 [details, diff]
Fix compilation with gcc-10

Patch to fix compilation with gcc-10
Comment 11 Joonas Niilola gentoo-dev 2020-11-18 07:55:25 UTC
Hi, could you make a Github pull request with your changes, as your patches are un-mergeable as-is without a proper sign-off.
  https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin

Note that you can't modify the existing ebuild with all of your changes in here, you should make a new revbump with EAPI-7 and all your changes, and reset KEYWORDS to ~.
Comment 12 Larry the Git Cow gentoo-dev 2020-11-28 17:46:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21c3d9ba810ae35fe90b7a5c5ba0ebdb6b502f70

commit 21c3d9ba810ae35fe90b7a5c5ba0ebdb6b502f70
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-06-29 21:38:48 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2020-11-28 17:46:40 +0000

    app-misc/rox-filer: fix compilation with GCC10
    
    Updated ebuild to EAPI7, fixed compilation with -fno-common.
    Closes: https://bugs.gentoo.org/710330
    Package-Manager: Portage-2.3.99, Repoman-2.3.23
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16499
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 .../rox-filer/files/rox-filer-2.11-gcc10.patch     | 27 ++++++++++++++++++++++
 app-misc/rox-filer/metadata.xml                    |  1 +
 app-misc/rox-filer/rox-filer-2.11.ebuild           | 26 ++++++++++++---------
 3 files changed, 43 insertions(+), 11 deletions(-)