CI (pkgcore) throws RedundantDodir warnings when package will do > dodir /some/path > insinto /some/path > newins "${FILESDIR}"/foo bar However, current documentation (https://devmanual.gentoo.org/function-reference/install-functions/) just says > insinto: Change install location for doins, newins and > dodir: Install a directory that will be non-empty when the package is merged. For directories that will be empty, please use keepdir instead. So it is not clear that insinto will actually take care of creating target directory if missing. And if you are familiar with tools like 'install' which will fail if target directory is missing, the behavior of insinto is unexpected and requires additional documentation.
insinto doesn't create the directory. doins/newins create any necessary parent directories before copying the files.
Apologies, I am mistaken.
PMS reference: https://projects.gentoo.org/pms/7/pms.html#x1-13000012.3.10
Created attachment 614764 [details, diff] function-reference/install-functions: Explain that *into creates the dir. Suggested patch, please review.
Created attachment 614766 [details, diff] function-reference/install-functions: Explain that *into creates the dir. Update, with typo fixed.
CC'ing portage team: Like Mike noted in IRC yesterday, we also need to adjust https://gitweb.gentoo.org/proj/portage.git/tree/man/ebuild.5?h=portage-2.3.89#n1456
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=054fc8a60b07ce387de5d2cf5467e937431d8183 commit 054fc8a60b07ce387de5d2cf5467e937431d8183 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2020-02-20 19:17:03 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2020-02-24 07:12:39 +0000 function-reference/install-functions: Explain that *into creates the dir. Closes: https://bugs.gentoo.org/710318 Signed-off-by: Ulrich Müller <ulm@gentoo.org> function-reference/install-functions/text.xml | 4 ++++ 1 file changed, 4 insertions(+)
