Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710254 - sys-apps/dstat: invalid use of python-r1
Summary: sys-apps/dstat: invalid use of python-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Paul Healy
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-02-19 20:53 UTC by Michał Górny
Modified: 2020-03-03 14:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-02-19 20:53:39 UTC
The ebuild inherits python-r1 but does not use any of its functions.
Comment 1 Paul Healy 2020-03-01 16:33:51 UTC
Added: https://github.com/gentoo/gentoo/pull/14814

This now correctly installs the wrappers so that:

# dstat --version|grep Python
Python 3.7.6 (default, Dec 23 2019, 15:48:34) 
# eselect python set python3.6
# dstat --version|grep Python
Python 3.6.10 (default, Feb 29 2020, 12:34:32) 
# eselect python set python2.7
# dstat --version|grep Python
Python 2.7.17 (default, Feb 29 2020, 12:35:54) 
#

Thanks!

Paul
Comment 2 Larry the Git Cow gentoo-dev 2020-03-03 14:54:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c27c310203920042096ade5157c985854d1b1487

commit c27c310203920042096ade5157c985854d1b1487
Author:     Paul Healy <lmiphay@gmail.com>
AuthorDate: 2020-03-01 16:28:17 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-03-03 14:53:44 +0000

    sys-apps/dstat: correct python-r1 usage
    
    1. Call python_foreach_impl instead of the upstream make install target
    2. Install the rest of the files using install functions
    3. Follow https://dev.gentoo.org/~mgorny/python-guide/multi.html for
       REQUIRED_USE/RDEPEND/DEPEND values.
    
    Closes: https://bugs.gentoo.org/710254
    Signed-off-by: Paul Healy <lmiphay@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/14814
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sys-apps/dstat/dstat-0.7.4-r1.ebuild | 59 ++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)