Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 710136 - media-tv/mythtv: ebuild enhancements
Summary: media-tv/mythtv: ebuild enhancements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wilson M. Michaels
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-02-19 07:44 UTC by Joonas Niilola
Modified: 2020-03-02 19:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2020-02-19 07:44:14 UTC
1. Please switch COMMON variable to COMMON_DEPEND which is widely used in Gentoo portage. 

2. You have a huge list of files that don't respect CFLAGS, 
 * Messages for package media-tv/mythtv-30.0_p20190808-r2:

 * QA Notice: Files built without respecting CFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/mythfrontend.real
 * /usr/bin/mythexternrecorder
 * /usr/bin/mythfilerecorder
 * /usr/bin/mythbackend
 * /usr/bin/mythtv-setup
 * /usr/bin/mythmetadatalookup
 * /usr/bin/mythfilldatabase
 * /usr/bin/mythscreenwizard
 * /usr/bin/mythccextractor
 * /usr/bin/mythmediaserver
 * /usr/bin/mythpreviewgen
 * /usr/bin/mythutil
 * /usr/bin/mythshutdown
 * /usr/bin/mythwelcome
 * /usr/bin/mythlcdserver
 * /usr/bin/mythjobqueue
 * /usr/bin/mythavtest
 * /usr/lib64/libmythmetadata-30.so.30.0.0
 * /usr/lib64/libmythprotoserver-30.so.30.0.0
 * /usr/lib64/libmythupnp-30.so.30.0.0
 * /usr/lib64/libmythui-30.so.30.0.0
 * /usr/lib64/libmythservicecontracts-30.so.30.0.0
 * /usr/lib64/libmythfreemheg-30.so.30.0.0

  Please either patch them to respect user-set CFLAGS, or include them in QA_PREBUILT list.

3. Please look into switching piped 'find' commands to simply call -exec instead.
Comment 1 Larry the Git Cow gentoo-dev 2020-02-21 06:08:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b2225059e74a0f9caf6081ddfa140a7613b01d0

commit 9b2225059e74a0f9caf6081ddfa140a7613b01d0
Author:     Wilson Michaels <thebitpit@earthlink.net>
AuthorDate: 2020-02-20 20:10:54 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-02-21 05:30:03 +0000

    media-tv/mythtv: ebuild enhancements
    
    Closes: https://bugs.gentoo.org/710136
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Wilson Michaels <thebitpit@earthlink.net>
    Closes: https://github.com/gentoo/gentoo/pull/14719
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-tv/mythtv/mythtv-30.0_p20190808-r2.ebuild | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)