Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 709986 - sys-apps/flashrom should install libflashrom (PATCH)
Summary: sys-apps/flashrom should install libflashrom (PATCH)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords: PATCH
Depends on: 712500
Blocks:
  Show dependency tree
 
Reported: 2020-02-17 20:32 UTC by Joakim Tjernlund
Modified: 2020-06-05 17:25 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Tjernlund 2020-02-17 20:32:30 UTC
fwupd can use libflashrom(as of 1.2 that was just released) to update FW.
Comment 1 Joakim Tjernlund 2020-03-05 17:30:05 UTC
Ping?

Would be nice if we had libflashrom before the next fwdupd release
Comment 2 Joakim Tjernlund 2020-03-19 02:04:03 UTC
This seems to do it(and update to 1.2 as well):
--- /usr/portage/sys-apps/flashrom/flashrom-1.1.ebuild	2020-01-16 00:20:58.909786791 +0100
+++ flashrom-1.2.ebuild	2020-03-19 03:02:23.634130649 +0100
@@ -41,6 +41,7 @@
 	+linux-mtd
 	+linux-spi
 	mstarddc-spi
+	ni845x-spi
 	+nic3com
 	+nicintel
 	+nicintel-eeprom
@@ -54,6 +55,7 @@
 	+satamv
 	+satasii
 	+serprog
+	stlinkv3-spi
 	+usbblaster-spi
 "
 
@@ -135,7 +137,7 @@
 	fi
 
 	tc-export AR CC PKG_CONFIG RANLIB
-	emake WARNERROR=no "${args[@]}"
+	emake WARNERROR=no "${args[@]}" all libflashrom.a
 }
 
 src_test() {
@@ -150,6 +152,8 @@
 	dosbin flashrom
 	doman flashrom.8
 	dodoc README Documentation/*.txt
+	dolib.a libflashrom.a
+	doheader libflashrom.h
 
 	if use tools ; then
 		if use amd64 ; then
Comment 3 Joakim Tjernlund 2020-03-22 17:54:18 UTC
Seems Peter is MIA?
Comment 4 Joakim Tjernlund 2020-03-23 08:10:59 UTC
Perhaps Lars wants to maintain it?
Comment 5 Marek Szuba archtester gentoo-dev 2020-03-26 21:41:16 UTC
I'll make sure this is supported in the ebuild for 1.2. Have you by any chance had an opportunity to see how this should be enabled in their Meson scripts? Although the README continues to suggest using the Makefile, I want to see if we could switch to Meson already and make new ebuilds simpler.
Comment 6 Joakim Tjernlund 2020-03-27 08:42:16 UTC
(In reply to Marek Szuba from comment #5)
> I'll make sure this is supported in the ebuild for 1.2. Have you by any
> chance had an opportunity to see how this should be enabled in their Meson
> scripts? Although the README continues to suggest using the Makefile, I want
> to see if we could switch to Meson already and make new ebuilds simpler.

meson? flashrom is just Makefiles
if you mean fwupd so no but there is an comment in the ebuild one could try
Comment 7 Marek Szuba archtester gentoo-dev 2020-03-27 09:53:33 UTC
(In reply to Joakim Tjernlund from comment #6)

> meson? flashrom is just Makefiles

Not any more, now there are both Makefiles and Meson files. Looking at commit history on GitHub, support for Meson got merged into master in December 2018 - and seeing as latest changes are less than four weeks old, it continues to be updated.
Comment 8 Joakim Tjernlund 2020-03-27 09:57:46 UTC
(In reply to Marek Szuba from comment #7)
> (In reply to Joakim Tjernlund from comment #6)
> 
> > meson? flashrom is just Makefiles
> 
> Not any more, now there are both Makefiles and Meson files. Looking at
> commit history on GitHub, support for Meson got merged into master in
> December 2018 - and seeing as latest changes are less than four weeks old,
> it continues to be updated.

Oh, I had not noticed, sorry.

On another note, fwupd will soon require jcat:
  https://github.com/hughsie/libjcat
any chance you can take that too?
Comment 9 Marek Szuba archtester gentoo-dev 2020-03-27 10:40:57 UTC
Looks simple enough, if nobody else takes care of before I have a chance (unfortunately I might have problems with Internet access for the next couple of weeks) I'll give it a shot.
Comment 10 Larry the Git Cow gentoo-dev 2020-03-30 22:42:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de4384a216e0ea905d4d509e7b881a97677c4736

commit de4384a216e0ea905d4d509e7b881a97677c4736
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-03-30 22:31:59 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-03-30 22:40:10 +0000

    sys-apps/flashrom: bump to 1.2
    
    Turns out the Meson scripts are incomplete for now (e.g. no libftdi
    dependency for usbblaster-spi in spite of the source code referencing
    the relevant header files, no jlink-spi support) so let us continue to
    use the Makefiles.
    
    Closes: https://bugs.gentoo.org/712500
    Closes: https://bugs.gentoo.org/709986
    Closes: https://bugs.gentoo.org/707304
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 sys-apps/flashrom/Manifest            |   1 +
 sys-apps/flashrom/flashrom-1.2.ebuild | 154 ++++++++++++++++++++++++++++++++++
 2 files changed, 155 insertions(+)
Comment 11 Joakim Tjernlund 2020-03-31 07:36:38 UTC
(In reply to Larry the Git Cow from comment #10)
> The bug has been closed via the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=de4384a216e0ea905d4d509e7b881a97677c4736
> 
> commit de4384a216e0ea905d4d509e7b881a97677c4736
> Author:     Marek Szuba <marecki@gentoo.org>
> AuthorDate: 2020-03-30 22:31:59 +0000
> Commit:     Marek Szuba <marecki@gentoo.org>
> CommitDate: 2020-03-30 22:40:10 +0000
> 
>     sys-apps/flashrom: bump to 1.2
>     
>     Turns out the Meson scripts are incomplete for now (e.g. no libftdi
>     dependency for usbblaster-spi in spite of the source code referencing
>     the relevant header files, no jlink-spi support) so let us continue to
>     use the Makefiles.
>     
>     Closes: https://bugs.gentoo.org/712500
>     Closes: https://bugs.gentoo.org/709986
>     Closes: https://bugs.gentoo.org/707304
>     Signed-off-by: Marek Szuba <marecki@gentoo.org>
> 
>  sys-apps/flashrom/Manifest            |   1 +
>  sys-apps/flashrom/flashrom-1.2.ebuild | 154
> ++++++++++++++++++++++++++++++++++
>  2 files changed, 155 insertions(+)

Thanks, now we are all good for next fwupd releas :)