Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 709662 - sys-devel/glibc-2.30/2.31 clobbers some syscall parameters on sparc (app-shells/fish-3.0.2: test hangs)
Summary: sys-devel/glibc-2.30/2.31 clobbers some syscall parameters on sparc (app-shel...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL: https://github.com/fish-shell/fish-sh...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2020-02-14 21:18 UTC by Rolf Eike Beer
Modified: 2020-06-10 08:17 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,179.30 KB, text/plain)
2020-02-14 21:18 UTC, Rolf Eike Beer
Details
glibc-2.31-sparc-patch1-reg-kabi.patch (glibc-2.31-sparc-patch1-reg-kabi.patch,8.33 KB, patch)
2020-06-08 08:08 UTC, Sergei Trofimovich (RETIRED)
Details | Diff
glibc-2.31-sparc-patch2-reg-fix-clobber.patch (glibc-2.31-sparc-patch2-reg-fix-clobber.patch,6.70 KB, patch)
2020-06-08 08:09 UTC, Sergei Trofimovich (RETIRED)
Details | Diff
glibc-2.30-sparc-reg-fix-clobber.patch (glibc-2.30-sparc-reg-fix-clobber.patch,5.96 KB, patch)
2020-06-08 21:43 UTC, Sergei Trofimovich (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer archtester 2020-02-14 21:18:34 UTC
Created attachment 613866 [details]
build.log

The problem is a "dirname" process that becomes a zombie. It's reproducible on sparc.

Portage 2.3.84 (python 3.6.9-final-0, default/linux/sparc/17.0, gcc-9.2.0, glibc-2.30-r2, 5.5.2-sparc64 sparc64)
=================================================================
System uname: Linux-5.5.2-sparc64-sparc64-sun4v-with-gentoo-2.6
KiB Mem:    33079800 total,  15868008 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Fri, 14 Feb 2020 01:15:01 +0000
Head commit of repository gentoo: 542ac4493fb6ec1442a58cf4f29efa8433e096af
sh bash 5.0_p11
ld GNU ld (Gentoo 2.33.1 p2) 2.33.1
app-shells/bash:          5.0_p11::gentoo
dev-lang/perl:            5.30.1::gentoo
dev-lang/python:          2.7.16::gentoo, 3.5.7::gentoo, 3.6.9::gentoo
dev-util/cmake:           3.16.0::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.17::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.15.1-r2::gentoo
sys-devel/binutils:       2.33.1-r1::gentoo
sys-devel/gcc:            9.2.0-r3::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.30-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.de.gentoo.org/gentoo-portage/
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

qt
    location: /var/lib/layman/qt
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="sparc ~sparc"
ACCEPT_LICENSE="@FREE"
CBUILD="sparc-unknown-linux-gnu"
CFLAGS="-O2 -mcpu=niagara2 -pipe -Wcast-align"
CHOST="sparc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -mcpu=niagara2 -pipe -Wcast-align"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS=""
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS=""
GENTOO_MIRRORS="ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j20 -l40"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl berkdb big-endian bzip2 cli crypt cxx dri fortran gdbm iconv ipv6 libtirpc ncurses nls nptl openmp pam pcre readline sparc split-usr ssl tcpd unicode xattr zlib" ADA_TARGET="gnat_2018" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24" USERLAND="GNU" VIDEO_CARDS="fbdev glint mga r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Georgy Yakovlev archtester gentoo-dev 2020-02-16 21:11:03 UTC
what about 3.1.0 ?
Comment 2 Rolf Eike Beer archtester 2020-02-19 13:42:49 UTC
Hangs the same. It's not specific to "dirname", there are other binaries (e.g. "rm") that hang the same sometimes.
Comment 3 Rolf Eike Beer archtester 2020-04-09 09:07:05 UTC
The backtrace is:

#0  0x700fa9e0 in job_t::continue_job(bool) ()
#1  0x700aafb8 in exec_job(parser_t&, std::shared_ptr<job_t>) ()
#2  0x7012f448 in parse_execution_context_t::run_1_job(tnode_t<grammar::job>, block_t const*) ()
#3  0x7012fbe8 in parse_execution_context_t::run_job_conjunction(tnode_t<grammar::job_conjunction>, block_t const*) ()
#4  0x70133c0c in parse_execution_result_t parse_execution_context_t::run_job_list<grammar::job_list>(tnode_t<grammar::job_list>, block_t const*) ()
#5  0x7013118c in parse_execution_context_t::eval_node(tnode_t<grammar::job_list>, block_t const*, io_chain_t const&) ()
#6  0x700f0f5c in int parser_t::eval_node<grammar::job_list>(std::shared_ptr<parsed_source_t const>, tnode_t<grammar::job_list>, io_chain_t const&, block_type_t, std::shared_ptr<job_t>) ()
#7  0x700ee330 in parser_t::eval(std::shared_ptr<parsed_source_t const>, io_chain_t const&, block_type_t) ()
#8  0x700efe5c in parser_t::eval(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, io_chain_t const&, block_type_t) ()
#9  0x700acdf0 in exec_subshell_internal(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, std::vector<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::allocator<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > > >*, bool, bool) ()
#10 0x700b1d14 in expand_cmdsubst(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, std::vector<completion_t, std::allocator<completion_t> >*, std::vector<parse_error_t, std::allocator<parse_error_t> >*) ()
#11 0x700b25ec in expand_stage_cmdsubst(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::vector<completion_t, std::allocator<completion_t> >*, int, std::vector<parse_error_t, std::allocator<parse_error_t> >*) ()
#12 0x700b0570 in expand_string(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::vector<completion_t, std::allocator<completion_t> >*, int, std::vector<parse_error_t, std::allocator<parse_error_t> >*) ()
#13 0x7012b130 in parse_execution_context_t::expand_arguments_from_nodes(std::vector<tnode_t<grammar::argument>, std::allocator<tnode_t<grammar::argument> > > const&, std::vector<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::allocator<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > > >*, parse_execution_context_t::globspec_t) ()
#14 0x7012c974 in parse_execution_context_t::populate_plain_process(job_t*, process_t*, tnode_t<grammar::plain_statement>) ()
#15 0x7012d7b0 in parse_execution_context_t::populate_job_process(job_t*, process_t*, tnode_t<grammar::statement>) ()
#16 0x7012df4c in parse_execution_context_t::populate_job_from_job_node(job_t*, tnode_t<grammar::job>, block_t const*) ()
#17 0x7012f564 in parse_execution_context_t::run_1_job(tnode_t<grammar::job>, block_t const*) ()
#18 0x7012fbe8 in parse_execution_context_t::run_job_conjunction(tnode_t<grammar::job_conjunction>, block_t const*) ()
#19 0x70133c0c in parse_execution_result_t parse_execution_context_t::run_job_list<grammar::job_list>(tnode_t<grammar::job_list>, block_t const*) ()
#20 0x7013118c in parse_execution_context_t::eval_node(tnode_t<grammar::job_list>, block_t const*, io_chain_t const&) ()
#21 0x700f0f5c in int parser_t::eval_node<grammar::job_list>(std::shared_ptr<parsed_source_t const>, tnode_t<grammar::job_list>, io_chain_t const&, block_type_t, std::shared_ptr<job_t>) ()
#22 0x700ade34 in void internal_exec_helper<grammar::job_list>(parser_t&, std::shared_ptr<parsed_source_t const>, tnode_t<grammar::job_list>, io_chain_t const&, std::shared_ptr<job_t>) ()
#23 0x700ab510 in exec_job(parser_t&, std::shared_ptr<job_t>) ()
#24 0x7012f448 in parse_execution_context_t::run_1_job(tnode_t<grammar::job>, block_t const*) ()
#25 0x7012fbe8 in parse_execution_context_t::run_job_conjunction(tnode_t<grammar::job_conjunction>, block_t const*) ()
#26 0x70133c0c in parse_execution_result_t parse_execution_context_t::run_job_list<grammar::job_list>(tnode_t<grammar::job_list>, block_t const*) ()
#27 0x7013118c in parse_execution_context_t::eval_node(tnode_t<grammar::job_list>, block_t const*, io_chain_t const&) ()
#28 0x700f0f5c in int parser_t::eval_node<grammar::job_list>(std::shared_ptr<parsed_source_t const>, tnode_t<grammar::job_list>, io_chain_t const&, block_type_t, std::shared_ptr<job_t>) ()
#29 0x700ee330 in parser_t::eval(std::shared_ptr<parsed_source_t const>, io_chain_t const&, block_type_t) ()
#30 0x700efe5c in parser_t::eval(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, io_chain_t const&, block_type_t) ()
#31 0x700acdf0 in exec_subshell_internal(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, std::vector<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::allocator<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > > >*, bool, bool) ()
#32 0x700b1d14 in expand_cmdsubst(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, std::vector<completion_t, std::allocator<completion_t> >*, std::vector<parse_error_t, std::allocator<parse_error_t> >*) ()
#33 0x700b25ec in expand_stage_cmdsubst(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::vector<completion_t, std::allocator<completion_t> >*, int, std::vector<parse_error_t, std::allocator<parse_error_t> >*) ()
#34 0x700b0570 in expand_string(std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::vector<completion_t, std::allocator<completion_t> >*, int, std::vector<parse_error_t, std::allocator<parse_error_t> >*) ()
#35 0x7012b130 in parse_execution_context_t::expand_arguments_from_nodes(std::vector<tnode_t<grammar::argument>, std::allocator<tnode_t<grammar::argument> > > const&, std::vector<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::allocator<std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > > >*, parse_execution_context_t::globspec_t) ()
#36 0x7012c974 in parse_execution_context_t::populate_plain_process(job_t*, process_t*, tnode_t<grammar::plain_statement>) ()
#37 0x7012d7b0 in parse_execution_context_t::populate_job_process(job_t*, process_t*, tnode_t<grammar::statement>) ()
#38 0x7012df4c in parse_execution_context_t::populate_job_from_job_node(job_t*, tnode_t<grammar::job>, block_t const*) ()
#39 0x7012f564 in parse_execution_context_t::run_1_job(tnode_t<grammar::job>, block_t const*) ()
#40 0x7012fbe8 in parse_execution_context_t::run_job_conjunction(tnode_t<grammar::job_conjunction>, block_t const*) ()
#41 0x70133c0c in parse_execution_result_t parse_execution_context_t::run_job_list<grammar::job_list>(tnode_t<grammar::job_list>, block_t const*) ()
#42 0x7013118c in parse_execution_context_t::eval_node(tnode_t<grammar::job_list>, block_t const*, io_chain_t const&) ()
#43 0x700f0f5c in int parser_t::eval_node<grammar::job_list>(std::shared_ptr<parsed_source_t const>, tnode_t<grammar::job_list>, io_chain_t const&, block_type_t, std::shared_ptr<job_t>) ()
#44 0x700ee330 in parser_t::eval(std::shared_ptr<parsed_source_t const>, io_chain_t const&, block_type_t) ()
#45 0x700ff438 in read_ni(int, io_chain_t const&) ()
#46 0x70109c80 in reader_read(int, io_chain_t const&) ()
#47 0x70033af4 in main ()

What it does the whole time is just this:

_newselect(6, [5], NULL, NULL, {tv_sec=0, tv_usec=10000}) = 0 (Timeout)
_newselect(6, [5], NULL, NULL, {tv_sec=0, tv_usec=10000}) = 0 (Timeout)
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2020-06-08 08:07:57 UTC
It's most likely a sparc glibc bug.
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2020-06-08 08:08:45 UTC
Created attachment 643924 [details, diff]
glibc-2.31-sparc-patch1-reg-kabi.patch
Comment 6 Sergei Trofimovich (RETIRED) gentoo-dev 2020-06-08 08:09:13 UTC
Created attachment 643926 [details, diff]
glibc-2.31-sparc-patch2-reg-fix-clobber.patch
Comment 7 Sergei Trofimovich (RETIRED) gentoo-dev 2020-06-08 08:11:11 UTC
For glibc-2.30 it might be a bit problematic to backport. Would be easier to reimplement local variable store.

I suggest fast-stabilizing glibc-2.31 on sparc instead if attached glibc-2.31-sparc-patch1-reg-kabi.patch and glibc-2.31-sparc-patch2-reg-fix-clobber.patch do help sparc64 userland. I'll test on sparc32 soon.
Comment 8 Sergei Trofimovich (RETIRED) gentoo-dev 2020-06-08 21:43:00 UTC
Created attachment 644024 [details, diff]
glibc-2.30-sparc-reg-fix-clobber.patch

glibc-2.31 does not exhibit the bug as-is. Probably due to unrelated changes. 

glibc-2.30-sparc-reg-fix-clobber.patch is a manual port of register clobber to glibc-2.30. I hope I didn't shuffle registers around by accident.

The patch fixes at least sigprocmask clobbers for me.
Comment 9 Sergei Trofimovich (RETIRED) gentoo-dev 2020-06-08 21:44:52 UTC
Let's reassign to toolchain@ at least for hangups.
Comment 10 Larry the Git Cow gentoo-dev 2020-06-08 22:04:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=97e3d34a588fad1db19369bbe9787d1c21fc3616

commit 97e3d34a588fad1db19369bbe9787d1c21fc3616
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-06-08 22:03:43 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-06-08 22:04:23 +0000

    sys-libs/glibc: backport sparc register clobber to 2.30, 2.31
    
    Initially reported by Rolf Eike Beer as test hangups
    on app-shells/fish-3.0.2 and nailed down by ridiculousfish
    as as breakage in `posix_spawn` implementation where
    one of syscall parameters was clobbered before being
    passed to kernel.
    
    Both glibc-2.30 and 2.31 got a backport of upstream commit
    c261718b3fda ("sparc: Avoid clobbering register parameters in syscall").
    
    Reported-by: Rolf Eike Beer
    Bug: https://bugs.gentoo.org/709662
    Bug: https://github.com/fish-shell/fish-shell/issues/6878
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-libs/glibc/Manifest             |    3 +
 sys-libs/glibc/glibc-2.30-r9.ebuild | 1468 ++++++++++++++++++++++++++++++++++
 sys-libs/glibc/glibc-2.31-r4.ebuild | 1478 +++++++++++++++++++++++++++++++++++
 3 files changed, 2949 insertions(+)
Comment 11 Sergei Trofimovich (RETIRED) gentoo-dev 2020-06-08 22:11:02 UTC
If sys-libs/glibc-2.30-r9 works better for you I suggest fast-stabilizing it for sparc only. I suspect GNU make is severely affected by that.
Comment 12 Rolf Eike Beer archtester 2020-06-09 06:05:36 UTC
I don't remember seeing anything remotely like this when using make, and you know best that my machine runs make all the day. Maybe it uses a different syscall or something there.

Anyway, I'll update both my main machine as well as my stable chroot with 2.30-r9 shortly and let it run my usual stuff for a day or two, and also test it with fish.
Comment 13 Larry the Git Cow gentoo-dev 2020-06-10 08:17:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=38a0ceac7f3fdbda01091bdb9a041662945aa582

commit 38a0ceac7f3fdbda01091bdb9a041662945aa582
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-06-10 08:17:12 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-06-10 08:17:31 +0000

    sys-libs/glibc: stable 2.30-r9 for sparc
    
    Fast-stabilize on sparc to move users faster off glibc
    with miscompiled syscall wrappers.
    
    Reported-by: Rolf Eike Beer
    Closes: https://bugs.gentoo.org/709662
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-libs/glibc/glibc-2.30-r9.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)