Seems like this was missed in code review... and no one tested it either. https://github.com/gentoo/genkernel/commit/db94e5a20cd0a9bd458a3a3df515f5e47985dab5#diff-bbaaf7bbb4eb38b81c622940a016dd89R715 Hint: `true | false` `true || false`
(In reply to n3ph from comment #0) > Seems like this was missed in code review... and no one tested it either. Thanks for the catch. I'll fix it. But please note that this is dead code. splash_geninitramfs isn't available anymore for most users so there is also no chance to test. Most please will probably run into https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=a6223abe3b87bc544445f1b2ee51019084209181
https://github.com/gentoo/genkernel/pull/12
(In reply to Thomas Deutschmann from comment #1) > Thanks for the catch. I'll fix it. But please note that this is dead code. > splash_geninitramfs isn't available anymore for most users so there is also > no chance to test. Most please will probably run into > https://gitweb.gentoo.org/proj/genkernel.git/commit/ > ?id=a6223abe3b87bc544445f1b2ee51019084209181 Sorry - wasn't aware that you were already on the move to fix this… Anyhow, what do you mean by dead code? Fixing the OR operand the script is doing fine…
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=679f57ca2e331ef3f8751808989ef8f69b6434fe commit 679f57ca2e331ef3f8751808989ef8f69b6434fe Author: Michael Gerlach <n3ph@cccfr.de> AuthorDate: 2020-02-13 12:57:19 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2020-02-13 13:32:20 +0000 gen_initramfs.sh: append_splash(): Fix splash_geninitramfs error handling Closes: https://bugs.gentoo.org/709478 Signed-off-by: Michael Gerlach <n3ph@cccfr.de> Closes: https://github.com/gentoo/genkernel/pull/13 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> gen_initramfs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
