Version bumps to the following versions: games-engines/scummvm: 2.1.1 (https://github.com/gentoo/gentoo/pull/14524) games-engines/scummvm-tools: 2.1.0 (https://github.com/gentoo/gentoo/pull/14525) Reproducible: Always
Hi there! Is there any way I can help with speeding up the process of getting this merged?
Sorry for the wait. Joining the games team is the only seriously effective way to help but I see that you are upstream so I think you're already doing your bit. :) I decided to keep the word "engines" in the description as I think that is an important distinction. I was about to push these with some other changes but I don't think the "binprefix" patch should be dropped. There's no explanation of why it was added but "decompile" is way too generic a name to go into /usr/bin for such a little-used package. Autoconf provides a way to adjust binary names out of the box but this project does not use Autoconf. Are you aware of issues with the patch?
(In reply to James Le Cuirot from comment #2) > Sorry for the wait. Joining the games team is the only seriously effective > way to help but I see that you are upstream so I think you're already doing > your bit. :) Thanks for the feedback. I guess before I can even think about joining any Gentoo team officially, I have to gather *a lot* more experience, so I'll be limited to submit the patches as soon as we push out a new release :) > > I decided to keep the word "engines" in the description as I think that is > an important distinction. > Sure, I agree. > I was about to push these with some other changes but I don't think the > "binprefix" patch should be dropped. There's no explanation of why it was > added but "decompile" is way too generic a name to go into /usr/bin for such > a little-used package. Autoconf provides a way to adjust binary names out of > the box but this project does not use Autoconf. Are you aware of issues with > the patch? I might check again, but at the first try, the compilation failed with this patch enabled. However, since that could have been an issue on my side and since /usr/bin/decompile really is too generic, feel free to re-add the patch. Besides the compilation issues, it's possible that it will break the scummvm-tools GUI since I don't know right at the moment if it's simply looking for the binaries in $PATH only.
Any update?
(In reply to Sam James (sec padawan) from comment #4) > Any update? In the meantime, we released ScummVM 2.1.2 (no update for scummvm-tools this time though). I'll try to update this ASAP.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83da3122371d8b77fd13e83836041a3c56fb34cb commit 83da3122371d8b77fd13e83836041a3c56fb34cb Author: Henrik Pihl <ahvenas@gmail.com> AuthorDate: 2020-07-10 16:45:50 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2020-07-19 11:49:32 +0000 games-engines/scummvm-tools: Bump to 2.1.0 Migrate away from deprecated wxGTK slot. Bug: https://bugs.gentoo.org/708600 Signed-off-by: Henrik Pihl <ahvenas@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/16659 Signed-off-by: James Le Cuirot <chewi@gentoo.org> games-engines/scummvm-tools/Manifest | 1 + .../scummvm-tools/scummvm-tools-2.1.0.ebuild | 59 ++++++++++++++++++++++ 2 files changed, 60 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=397539cf575103d062648e38d9f2bdb80e0bed46 commit 397539cf575103d062648e38d9f2bdb80e0bed46 Author: Henrik Pihl <ahvenas@gmail.com> AuthorDate: 2020-07-10 16:45:50 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2020-07-19 11:49:29 +0000 games-engines/scummvm: Bump to 2.1.2 TTS patch removed, already merged upstream. Bug: https://bugs.gentoo.org/708600 Signed-off-by: Henrik Pihl <ahvenas@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/16659 Signed-off-by: James Le Cuirot <chewi@gentoo.org> games-engines/scummvm/Manifest | 1 + games-engines/scummvm/scummvm-2.1.2.ebuild | 110 +++++++++++++++++++++++++++++ 2 files changed, 111 insertions(+)
