Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708450 - media-gfx/sxiv-26: build failure with USE=-exif
Summary: media-gfx/sxiv-26: build failure with USE=-exif
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
: 708516 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-02-06 04:16 UTC by Naohiro Aota
Modified: 2020-02-07 02:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naohiro Aota gentoo-dev 2020-02-06 04:16:02 UTC 
USE=-exif emerge sxiv fails in the install phase with the following error.

>>> Install media-gfx/sxiv-26 into /dev/shm/portage/media-gfx/sxiv-26/image
make -j8 -l8 DESTDIR=/dev/shm/portage/media-gfx/sxiv-26/image PREFIX=/usr install 
GEN version.h
CC options.o
LINK sxiv
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lexif
collect2: error: ld returned 1 exit status
make: *** [Makefile:42: sxiv] Error 1
 * ERROR: media-gfx/sxiv-26::gentoo failed (install phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=media-gfx/sxiv-26::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=media-gfx/sxiv-26::gentoo'`.
 * The complete build log is located at '/dev/shm/portage/media-gfx/sxiv-26/temp/build.log'.
 * The ebuild environment file is located at '/dev/shm/portage/media-gfx/sxiv-26/temp/environment'.
 * Working directory: '/dev/shm/portage/media-gfx/sxiv-26/work/sxiv-26'
 * S: '/dev/shm/portage/media-gfx/sxiv-26/work/sxiv-26'


The "make" in the compile phase pass because we invoke with HAVE_LIBEXIF=0. But, the install phase tries to rebuild "sxiv" because version.h is updated, leading to the above link failure.

Since the "Makefile" have the following rule and we don't have ".git/index" in the archive, "version.h" is rebuilt unconditionally.

version.h: Makefile .git/index
        @echo "GEN $@"
...

We can drop ".git/index" from the rule to fix it.


Reproducible: Always

Steps to Reproduce:
1. USE=-exif emerge sxiv
Comment 1 Larry the Git Cow gentoo-dev 2020-02-06 04:56:08 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=70d37bf7e17f40f7953badc52302065bcc98d3f1

commit 70d37bf7e17f40f7953badc52302065bcc98d3f1
Author:     Tim Harder <radhermit@gentoo.org>
AuthorDate: 2020-02-06 04:54:11 +0000
Commit:     Tim Harder <radhermit@gentoo.org>
CommitDate: 2020-02-06 04:54:11 +0000

    media-gfx/sxiv: fix build failure due to install phase rebuild
    
    Closes: https://bugs.gentoo.org/708450
    Signed-off-by: Tim Harder <radhermit@gentoo.org>

 media-gfx/sxiv/sxiv-26.ebuild   | 2 ++
 media-gfx/sxiv/sxiv-9999.ebuild | 2 ++
 2 files changed, 4 insertions(+)
Comment 2 Tim Harder gentoo-dev 2020-02-07 02:22:21 UTC 
*** Bug 708516 has been marked as a duplicate of this bug. ***