Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708438 - net-proxy/redsocks-0.5: missing '--' before args in initd
Summary: net-proxy/redsocks-0.5: missing '--' before args in initd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matt Turner
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-02-06 01:16 UTC by Quentin Retornaz
Modified: 2020-02-08 17:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
redsocks.init replacement (redsocks.init,926 bytes, text/plain)
2020-02-06 01:46 UTC, Brian Evans (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Retornaz 2020-02-06 01:16:35 UTC
Hello,
`--` is missing before command args in initd.

Actually, it is as following:

        start-stop-daemon --start --exec "${REDSOCKS_BINARY}" \
            -p "${REDSOCKS_PIDFILE}" -c ${REDSOCKS_CONFIG}

        start-stop-daemon --stop --exec "${REDSOCKS_BINARY}" \
            -p "${REDSOCKS_PIDFILE}" -c "${REDSOCKS_CONFIG}"

        start-stop-daemon --signal HUP --exec "${REDSOCKS_BINARY}" \
            -p "${REDSOCKS_PIDFILE}" -c "${REDSOCKS_CONFIG}"

and it should be as:

        start-stop-daemon --start --exec "${REDSOCKS_BINARY}" \
            -- -p "${REDSOCKS_PIDFILE}" -c ${REDSOCKS_CONFIG}

        start-stop-daemon --stop --exec "${REDSOCKS_BINARY}" \
            -- -p "${REDSOCKS_PIDFILE}" -c "${REDSOCKS_CONFIG}"

        start-stop-daemon --signal HUP --exec "${REDSOCKS_BINARY}" \
            -- -p "${REDSOCKS_PIDFILE}" -c "${REDSOCKS_CONFIG}"
Comment 1 Brian Evans (RETIRED) gentoo-dev 2020-02-06 01:46:47 UTC
Created attachment 612056 [details]
redsocks.init replacement

If is to be updated, I'd suggest this instead to eliminate issues
Comment 2 Quentin Retornaz 2020-02-06 02:06:06 UTC
Followed your advice and updated PR
Comment 3 Larry the Git Cow gentoo-dev 2020-02-08 17:40:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d1fbcd0b68cb2af1ce4491604b7f64d3d12deb2

commit 8d1fbcd0b68cb2af1ce4491604b7f64d3d12deb2
Author:     Quentin Retornaz <gentoo@retornaz.com>
AuthorDate: 2020-02-06 01:19:51 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-02-08 17:40:14 +0000

    net-proxy/redsocks: fix command args in initd
    
    Closes: https://bugs.gentoo.org/708438
    Closes: https://github.com/gentoo/gentoo/pull/14575
    Signed-off-by: Quentin Retornaz <gentoo@retornaz.com>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 net-proxy/redsocks/files/redsocks.init-r1 | 43 +++++++++++++++++++++++++++
 net-proxy/redsocks/redsocks-0.5-r1.ebuild | 49 +++++++++++++++++++++++++++++++
 2 files changed, 92 insertions(+)