Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708202 - media-gfx/rawtherapee-5.8 version bump
Summary: media-gfx/rawtherapee-5.8 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Francesco Riosa
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-02-04 11:44 UTC by DrSlony
Modified: 2020-02-26 18:36 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DrSlony 2020-02-04 11:44:53 UTC
RawTherapee 5.8 has been released:
http://rawtherapee.com/downloads/5.8/
Comment 1 Francesco Riosa 2020-02-05 15:57:51 UTC
@DrSlony https://rawtherapee.com/shared/source/rawtherapee-5.8.tar.xz is not available (404)

when it will be I'll test the ebuild with differences below to enable also the tcmalloc linking.

Gentoo has the ability to enable a useflag (tcmalloc) by default, should we consider that for next releases (strictly > 5.8)?

--- rawtherapee-5.7.ebuild      2020-01-06 09:14:30.882982160 -0000
+++ rawtherapee-5.8.ebuild      2020-02-05 15:47:28.515208402 -0000
@@ -14,7 +14,7 @@
 SLOT="0"
 KEYWORDS="~amd64 ~x86"

-IUSE="openmp"
+IUSE="openmp tcmalloc"

 RDEPEND="
        dev-libs/expat
@@ -27,6 +27,7 @@
        media-libs/tiff:0
        sci-libs/fftw:3.0
        sys-libs/zlib
+       tcmalloc? ( dev-util/google-perftools )
        virtual/jpeg:0
        x11-libs/gtk+:3"
 DEPEND="${RDEPEND}
@@ -57,6 +58,7 @@
                -DLICENCEDIR=/usr/share/${PN}
                -DCACHE_NAME_SUFFIX=""
                -DWITH_SYSTEM_KLT="off"
+               -DENABLE_TCMALLOC=$(usex tcmalloc)
        )
        cmake_src_configure
 }
Comment 2 DrSlony 2020-02-05 20:42:20 UTC
Hey Francesco

> @DrSlony https://rawtherapee.com/shared/source/rawtherapee-5.8.tar.xz is not available (404)

Oops! Fixed now. Thanks for the heads up.

Regarding enabling tcmalloc by default, see:
https://github.com/Beep6581/RawTherapee/issues/4416
https://github.com/Beep6581/RawTherapee/pull/5465

There are problems on some systems with standard malloc not returning freed memory, leading to massively increases memory usage. This could result in filling up swap, slowing down the system and causing instability. For those systems, using tcmalloc seems to solve the problem.
Comment 3 Francesco Riosa 2020-02-07 10:03:58 UTC
both memory allocator were tested and both are ok on my box
Comment 4 Larry the Git Cow gentoo-dev 2020-02-26 18:36:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=666bf49931d7ac9897343ebb765837f8a5f9cc8b

commit 666bf49931d7ac9897343ebb765837f8a5f9cc8b
Author:     Francesco Riosa <friosa@gaikai.com>
AuthorDate: 2020-02-07 09:43:34 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-02-26 18:35:27 +0000

    media-gfx/rawtherapee: version bump to 5.8
    
    Signed-off-by: Francesco Riosa <vivo75@gmail.com>
    Closes: https://bugs.gentoo.org/708202
    Closes: https://github.com/gentoo/gentoo/pull/14590
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/rawtherapee/Manifest               |  1 +
 media-gfx/rawtherapee/rawtherapee-5.8.ebuild | 73 ++++++++++++++++++++++++++++
 2 files changed, 74 insertions(+)