Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 708190 - net-misc/packETH : add USE=cli
Summary: net-misc/packETH : add USE=cli
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-04 08:07 UTC by Joakim Tjernlund
Modified: 2020-02-04 09:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Tjernlund 2020-02-04 08:07:06 UTC
packETH also have a CLI version, see cli dir.
I could use a a CLI only USE flag for use on targets without X11/GUI
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2020-02-04 08:19:11 UTC
Maybe I am missing something, but I don't think I am missing something, so maybe you can explain how you accomplish that compile time configuration. In configure.ac it says quite clearly:

# We need GTK
pkg_modules="gtk+-2.0 >= 2.4 glib-2.0 >= 2.4 gthread-2.0 >= 2.4"
PKG_CHECK_MODULES(DEPS, [$pkg_modules])
Comment 2 Joakim Tjernlund 2020-02-04 08:40:23 UTC
(In reply to Jeroen Roovers from comment #1)
> Maybe I am missing something, but I don't think I am missing something, so
> maybe you can explain how you accomplish that compile time configuration. In
> configure.ac it says quite clearly:
> 
> # We need GTK
> pkg_modules="gtk+-2.0 >= 2.4 glib-2.0 >= 2.4 gthread-2.0 >= 2.4"
> PKG_CHECK_MODULES(DEPS, [$pkg_modules])

the cli seem to be independent of autotools. One jsut
unpack and do:
cd /var/tmp/portage/net-misc/packETH-2.1/work/packETH-2.1/cli
make
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2020-02-04 08:51:35 UTC
(In reply to Joakim Tjernlund from comment #2)
> (In reply to Jeroen Roovers from comment #1)
> > Maybe I am missing something, but I don't think I am missing something, so
> > maybe you can explain how you accomplish that compile time configuration. In
> > configure.ac it says quite clearly:
> > 
> > # We need GTK
> > pkg_modules="gtk+-2.0 >= 2.4 glib-2.0 >= 2.4 gthread-2.0 >= 2.4"
> > PKG_CHECK_MODULES(DEPS, [$pkg_modules])
> 
> the cli seem to be independent of autotools. One jsut
> unpack and do:
> cd /var/tmp/portage/net-misc/packETH-2.1/work/packETH-2.1/cli
> make

And see it catch fire because of -Werror. :-)
Comment 4 Larry the Git Cow gentoo-dev 2020-02-04 08:52:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9c4edea07ac15e9742774b877a200f67cae899a

commit c9c4edea07ac15e9742774b877a200f67cae899a
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-02-04 08:52:16 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-02-04 08:52:55 +0000

    net-misc/packETH: Add USE="cli gtk"
    
    Package-Manager: Portage-2.3.87, Repoman-2.3.20
    Closes: https://bugs.gentoo.org/708190
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-misc/packETH/metadata.xml       | 17 ++++++++++-------
 net-misc/packETH/packETH-2.1.ebuild | 35 ++++++++++++++++++++++++++++++-----
 2 files changed, 40 insertions(+), 12 deletions(-)
Comment 5 Joakim Tjernlund 2020-02-04 08:55:46 UTC
(In reply to Jeroen Roovers from comment #3)
> (In reply to Joakim Tjernlund from comment #2)
> > (In reply to Jeroen Roovers from comment #1)
> > > Maybe I am missing something, but I don't think I am missing something, so
> > > maybe you can explain how you accomplish that compile time configuration. In
> > > configure.ac it says quite clearly:
> > > 
> > > # We need GTK
> > > pkg_modules="gtk+-2.0 >= 2.4 glib-2.0 >= 2.4 gthread-2.0 >= 2.4"
> > > PKG_CHECK_MODULES(DEPS, [$pkg_modules])
> > 
> > the cli seem to be independent of autotools. One jsut
> > unpack and do:
> > cd /var/tmp/portage/net-misc/packETH-2.1/work/packETH-2.1/cli
> > make
> 
> And see it catch fire because of -Werror. :-)

Not with gcc 8.3.0 :)
But yes, the Makefile needs some tweaking
Comment 6 Joakim Tjernlund 2020-02-04 08:56:46 UTC
(In reply to Larry the Git Cow from comment #4)
> The bug has been closed via the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=c9c4edea07ac15e9742774b877a200f67cae899a
> 
> commit c9c4edea07ac15e9742774b877a200f67cae899a
> Author:     Jeroen Roovers <jer@gentoo.org>
> AuthorDate: 2020-02-04 08:52:16 +0000
> Commit:     Jeroen Roovers <jer@gentoo.org>
> CommitDate: 2020-02-04 08:52:55 +0000
> 
>     net-misc/packETH: Add USE="cli gtk"
>     
>     Package-Manager: Portage-2.3.87, Repoman-2.3.20
>     Closes: https://bugs.gentoo.org/708190
>     Signed-off-by: Jeroen Roovers <jer@gentoo.org>
> 
>  net-misc/packETH/metadata.xml       | 17 ++++++++++-------
>  net-misc/packETH/packETH-2.1.ebuild | 35 ++++++++++++++++++++++++++++++-----
>  2 files changed, 40 insertions(+), 12 deletions(-)

Nice, testing now ...
Comment 7 Joakim Tjernlund 2020-02-04 09:01:43 UTC
(In reply to Joakim Tjernlund from comment #6)
> (In reply to Larry the Git Cow from comment #4)
> > The bug has been closed via the following commit(s):
> > 
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/
> > ?id=c9c4edea07ac15e9742774b877a200f67cae899a
> > 
> > commit c9c4edea07ac15e9742774b877a200f67cae899a
> > Author:     Jeroen Roovers <jer@gentoo.org>
> > AuthorDate: 2020-02-04 08:52:16 +0000
> > Commit:     Jeroen Roovers <jer@gentoo.org>
> > CommitDate: 2020-02-04 08:52:55 +0000
> > 
> >     net-misc/packETH: Add USE="cli gtk"
> >     
> >     Package-Manager: Portage-2.3.87, Repoman-2.3.20
> >     Closes: https://bugs.gentoo.org/708190
> >     Signed-off-by: Jeroen Roovers <jer@gentoo.org>
> > 
> >  net-misc/packETH/metadata.xml       | 17 ++++++++++-------
> >  net-misc/packETH/packETH-2.1.ebuild | 35 ++++++++++++++++++++++++++++++-----
> >  2 files changed, 40 insertions(+), 12 deletions(-)
> 
> Nice, testing now ...

Nit, CC needs overding too, it is hardcoded to gcc
Comment 8 Larry the Git Cow gentoo-dev 2020-02-04 09:21:18 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cc9850529837ef703aedff1a5b59093371645587

commit cc9850529837ef703aedff1a5b59093371645587
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-02-04 09:18:51 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-02-04 09:21:14 +0000

    net-misc/packETH: Set CC for USE=cli
    
    Package-Manager: Portage-2.3.87, Repoman-2.3.20
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=708190
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-misc/packETH/packETH-2.1.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)