Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 707988 - www-client/chromium-81.0.4033.2 - mipmap-noise render issues under certain circumstances
Summary: www-client/chromium-81.0.4033.2 - mipmap-noise render issues under certain ci...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chromium Project
URL: https://bugs.chromium.org/p/chromium/...
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2020-02-03 04:20 UTC by Robin Kauffman
Modified: 2020-02-06 20:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Screenshot of Chromium 81.0.4033.2, showing the render error bug. (Chromium-81.0.4033.2_GNOME-Shell-2020012701.png,213.82 KB, image/png)
2020-02-03 04:20 UTC, Robin Kauffman
Details
Tom Anderson's patch forcing a redraw after a (WM-initiated?) resize of a browser window by invalidating the layout of the frame view. (chromium-81.0.4040.5-Fix-browser-frame-view-not-getting-a-relayout.patch,1.52 KB, patch)
2020-02-03 04:26 UTC, Robin Kauffman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Kauffman 2020-02-03 04:20:38 UTC
Created attachment 611162 [details]
Screenshot of Chromium 81.0.4033.2, showing the render error bug.

Hello-
    After compiling/installing/running Chromium 81.0.4033.2 (from the Gentoo repo, no longer in-tree), I noticed a bit of mipmap noise being drawn at the outer edge of the browser window (screenshot attached).  After submitting a bug to upstream ( https://crbug.com/1046122 ), thomasanderson@chromium.org suggested a patch that would fix it.  I applied it (to 81.0.4040.5, which unfortunately changed two things at once, and thus made it more difficult to deduce whether it was the patch itself that helped things), compiled (a newer version of) Chromium again, and noticed the issue had ceased.  The original Gerrit patch (which was applied against chromium/src.git master at the time) is at https://chromium-review.googlesource.com/c/chromium/src/+/2033759 , and after fetching it, I cherry-picked it atop the Chromium 81.0.4040.5 sources, and did a 'git format-patch HEAD^..HEAD).  The resultant patch (which can be applied in in any order, as it doesn't touch (to my knowledge) any files that other patches might fiddle with) is attached as well.
    I'll keep following up on the upstream bug, and hopefully will get around to quickpkg-ing the current Chromium build, trying to rebuild it without the patch, and seeing if the bug comes back.
    Sorry for the incomplete nature of this report (and I completely understand if you aren't excited about folding this patch into the main Gentoo tree), but I thought I'd share what (little) I had sussed out from my bug-watching escapades thus far.
Comment 1 Robin Kauffman 2020-02-03 04:26:39 UTC
Created attachment 611164 [details, diff]
Tom Anderson's patch forcing a redraw after a (WM-initiated?) resize of a browser window by invalidating the layout of the frame view.

This is Tom Anderson's patch, cherry-picked directly from the Gerrit repo in question ( https://chromium.googlesource.com/chromium/src ), and turned into a metadata-rich patch with 'git format-patch'.  Not technically necessary, but I wanted to make sure the commentary (and credit to Tom) remained intact.
Comment 2 Stephan Hartmann (RETIRED) gentoo-dev 2020-02-03 08:04:56 UTC
(In reply to Robin Kauffman from comment #1)
> Created attachment 611164 [details, diff] [details, diff]
> Tom Anderson's patch forcing a redraw after a (WM-initiated?) resize of a
> browser window by invalidating the layout of the frame view.
> 
> This is Tom Anderson's patch, cherry-picked directly from the Gerrit repo in
> question ( https://chromium.googlesource.com/chromium/src ), and turned into
> a metadata-rich patch with 'git format-patch'.  Not technically necessary,
> but I wanted to make sure the commentary (and credit to Tom) remained intact.

Thanks, let's see if this one gets backported to M81 branch. If not, I will add to next beta/dev channel release.

BTW: There is a "DOWNLOAD" Link in Gerrit where you can get the patch with all metadata much easier :)
Comment 3 Larry the Git Cow gentoo-dev 2020-02-06 20:48:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6d7418bd2939cff68b0d2f1678a9ba19fb05aba

commit e6d7418bd2939cff68b0d2f1678a9ba19fb05aba
Author:     Stephan Hartmann <stha09@googlemail.com>
AuthorDate: 2020-02-06 20:36:28 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-02-06 20:48:25 +0000

    www-client/chromium: dev channel bump to 81.0.4044.9
    
    Closes: https://bugs.gentoo.org/707988
    Package-Manager: Portage-2.3.76, Repoman-2.3.16
    Signed-off-by: Stephan Hartmann <stha09@googlemail.com>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/14585

 www-client/chromium/Manifest                       |   2 +-
 ...0.4040.5.ebuild => chromium-81.0.4044.9.ebuild} |   7 +-
 www-client/chromium/files/chromium-81-clang.patch  |  13 -
 .../files/chromium-81-fix-browser-frame.patch      |  35 +++
 .../chromium/files/chromium-81-gcc-constexpr.patch |  19 ++
 .../chromium/files/chromium-81-gcc-template.patch  |  32 ---
 www-client/chromium/files/chromium-81-mojom.patch  | 303 +++++++++++++++++++++
 .../chromium/files/chromium-compiler-r11.patch     |  51 ++--
 8 files changed, 381 insertions(+), 81 deletions(-)