Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 706816 - net-firewall/fwknop-2.6.10 : fails to build with -fno-common or gcc-10
Summary: net-firewall/fwknop-2.6.10 : fails to build with -fno-common or gcc-10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Hank Leininger
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2020-01-28 18:14 UTC by Toralf Förster
Modified: 2020-04-10 14:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,14.95 KB, text/plain)
2020-01-28 18:14 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,59.02 KB, text/plain)
2020-01-28 18:14 UTC, Toralf Förster
Details
environment (environment,157.49 KB, text/plain)
2020-01-28 18:14 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,12.36 KB, application/x-bzip)
2020-01-28 18:14 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,12.29 KB, application/x-bzip)
2020-01-28 18:14 UTC, Toralf Förster
Details
net-firewall:fwknop-2.6.10:20200127-211747.log (net-firewall:fwknop-2.6.10:20200127-211747.log,47.10 KB, text/plain)
2020-01-28 18:14 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,41.51 KB, application/x-bzip)
2020-01-28 18:14 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-01-28 18:14:39 UTC
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -I ../lib -I ../common   -O2 -pipe -march=native -fno-common -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2 -c -o fwknop-getpasswd.o `test -f 'getpasswd.c' || echo './'`getpasswd.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -I ../lib -I ../common   -O2 -pipe -march=native -fno-common -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2 -c -o fwknop-log_msg.o `test -f 'log_msg.c' || echo './'`log_msg.c
/bin/sh ../libtool  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc  -O2 -pipe -march=native -fno-common -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2  -Wl,-O1 -Wl,--as-needed -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -pie -fPIC -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -o fwknop fwknop-fwknop.o fwknop-config_init.o fwknop-spa_comm.o fwknop-utils.o fwknop-http_resolve_host.o fwknop-getpasswd.o fwknop-log_msg.o -L../common -lfko_util ../lib/libfko.la 
libtool: link: x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -fno-common -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2 -Wl,-O1 -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -pie -fPIC -D_FORTIFY_SOURCE=2 -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/fwknop fwknop-fwknop.o fwknop-config_init.o fwknop-spa_comm.o fwknop-utils.o fwknop-http_resolve_host.o fwknop-getpasswd.o fwknop-log_msg.o  -Wl,--as-needed -L../common -lfko_util ../lib/.libs/libfko.so
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: fwknop-config_init.o:(.bss+0x4): multiple definition of `log_level_t'; fwknop-fwknop.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: fwknop-spa_comm.o:(.bss+0x0): multiple definition of `log_level_t'; fwknop-fwknop.o:(.bss+0x0): first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_systemd-20200126-201521

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *


llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *




repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Mon, 27 Jan 2020 20:26:17 +0000

emerge -qpvO net-firewall/fwknop
[ebuild  N    ] net-firewall/fwknop-2.6.10  USE="client gdbm iptables server -extras -firewalld -gpg -nfqueue -python -udp-server" PYTHON_TARGETS="python2_7"
Comment 1 Toralf Förster gentoo-dev 2020-01-28 18:14:41 UTC
Created attachment 605900 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-01-28 18:14:44 UTC
Created attachment 605902 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-01-28 18:14:47 UTC
Created attachment 605904 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-01-28 18:14:50 UTC
Created attachment 605906 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-01-28 18:14:53 UTC
Created attachment 605908 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-01-28 18:14:56 UTC
Created attachment 605910 [details]
net-firewall:fwknop-2.6.10:20200127-211747.log
Comment 7 Toralf Förster gentoo-dev 2020-01-28 18:14:59 UTC
Created attachment 605912 [details]
temp.tbz2
Comment 8 Hank Leininger 2020-01-29 05:44:36 UTC
Reproduced, and submitted a fix upstream:

https://github.com/mrash/fwknop/pull/306

I will keep an eye on that, and either bump if upstream merges it into a new version, or update our ebuild with a patch if not.
Comment 9 Larry the Git Cow gentoo-dev 2020-04-10 14:58:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=023eef270a7c2239cb7bca2c0b059aff6a52eda3

commit 023eef270a7c2239cb7bca2c0b059aff6a52eda3
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2020-02-25 06:35:19 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-04-10 14:57:44 +0000

    net-firewall/fwknop: fix build with -fno-common or gcc-10
    
    Cherry-picked fix from
    https://github.com/Jakuje/fwknop/commit/a87325b0816a79329cf0b4d4f9ebf247ead117db
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/706816
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Closes: https://github.com/gentoo/gentoo/pull/14766
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/fwknop-2.6.10_fno-common_fix.patch       | 23 ++++++++++++++++++++++
 net-firewall/fwknop/fwknop-2.6.10-r1.ebuild        |  2 ++
 2 files changed, 25 insertions(+)