Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 706734 - sys-process/audit-2.8.5 : fails to build with -fno-common or gcc-10
Summary: sys-process/audit-2.8.5 : fails to build with -fno-common or gcc-10
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: SE Linux Bugs
URL: https://github.com/linux-audit/audit-...
Whiteboard:
Keywords: PATCH, UPSTREAM
: 727082 (view as bug list)
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2020-01-27 17:44 UTC by Toralf Förster
Modified: 2021-01-04 11:11 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,14.91 KB, text/plain)
2020-01-27 17:44 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,42.10 KB, text/plain)
2020-01-27 17:44 UTC, Toralf Förster
Details
environment (environment,151.05 KB, text/plain)
2020-01-27 17:44 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,11.85 KB, application/x-bzip)
2020-01-27 17:44 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,11.66 KB, application/x-bzip)
2020-01-27 17:44 UTC, Toralf Förster
Details
sys-process:audit-2.8.5:20200127-174027.log (sys-process:audit-2.8.5:20200127-174027.log,116.59 KB, text/plain)
2020-01-27 17:44 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,43.73 KB, application/x-bzip)
2020-01-27 17:44 UTC, Toralf Förster
Details
files/audit-2.8.5-fno-common.patch (audit-2.8.5-fno-common.patch,379 bytes, patch)
2020-02-14 09:07 UTC, Jeroen Roovers (RETIRED)
Details | Diff
sys-process/audit/audit-2.8.5-r1.ebuild (audit-2.8.5-r1.ebuild,6.32 KB, text/plain)
2020-06-10 22:34 UTC, Robin Johnson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-01-27 17:44:05 UTC
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/src -I..  -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5 -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/lib -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/src/libev -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/auparse  -D_GNU_SOURCE -Wno-pointer-sign -O2 -pipe -march=native -fno-common -c -o ausearch-avc.o /var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/src/ausearch-avc.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/src -I..  -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5 -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/lib -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/src/libev -I/var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/auparse  -D_GNU_SOURCE -Wno-pointer-sign -O2 -pipe -march=native -fno-common -c -o ausearch-lol.o /var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5/src/ausearch-lol.c
/bin/sh ../libtool  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc -D_GNU_SOURCE -Wno-pointer-sign -O2 -pipe -march=native -fno-common  -Wl,-O1 -Wl,--as-needed -o aureport aureport.o auditd-config.o ausearch-llist.o aureport-options.o ausearch-string.o ausearch-parse.o aureport-scan.o aureport-output.o ausearch-lookup.o ausearch-int.o ausearch-time.o ausearch-nvpair.o ausearch-avc.o ausearch-lol.o -L../lib -laudit -L../auparse -lauparse 
libtool: link: x86_64-pc-linux-gnu-gcc -D_GNU_SOURCE -Wno-pointer-sign -O2 -pipe -march=native -fno-common -Wl,-O1 -o .libs/aureport aureport.o auditd-config.o ausearch-llist.o aureport-options.o ausearch-string.o ausearch-parse.o aureport-scan.o aureport-output.o ausearch-lookup.o ausearch-int.o ausearch-time.o ausearch-nvpair.o ausearch-avc.o ausearch-lol.o  -Wl,--as-needed -L../lib -L../auparse /var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5-abi_x86_64.amd64/auparse/.libs/libauparse.so /var/tmp/portage/sys-process/audit-2.8.5/work/audit-2.8.5-abi_x86_64.amd64/lib/.libs/libaudit.so -lcap-ng
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-llist.o:(.bss+0x0): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: aureport-options.o:(.bss+0xa0): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_systemd-20200126-201521

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *


llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *




repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Mon, 27 Jan 2020 16:26:19 +0000

emerge -qpvO sys-process/audit
[ebuild  N    ] sys-process/audit-2.8.5  USE="(split-usr) -gssapi -ldap -python -static-libs" ABI_X86="(64) -32 (-x32)" PYTHON_TARGETS="python2_7 python3_6 -python3_7"
Comment 1 Toralf Förster gentoo-dev 2020-01-27 17:44:08 UTC
Created attachment 605656 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-01-27 17:44:11 UTC
Created attachment 605658 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-01-27 17:44:13 UTC
Created attachment 605660 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-01-27 17:44:16 UTC
Created attachment 605662 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-01-27 17:44:19 UTC
Created attachment 605664 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-01-27 17:44:21 UTC
Created attachment 605666 [details]
sys-process:audit-2.8.5:20200127-174027.log
Comment 7 Toralf Förster gentoo-dev 2020-01-27 17:44:24 UTC
Created attachment 605668 [details]
temp.tbz2
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2020-02-14 09:07:50 UTC
Created attachment 613750 [details, diff]
files/audit-2.8.5-fno-common.patch

Well, that was easy. One of these declarations is not like the others. 8-)
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2020-02-14 09:39:22 UTC
Also upstream.
Comment 10 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-04 10:51:44 UTC
*** Bug 727082 has been marked as a duplicate of this bug. ***
Comment 11 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2020-06-10 22:33:30 UTC
jer:
The upstream patch and your patch don't seem to be sufficent.

Somewhere it's got either another instance of it, or it's using the wrong libraries.

trying to use upstream latest commit 80866dc78b5db17010516e24344eaed8dcc6fb99 as a tarball since it includes this fix and others, and it fails with that same event_node_list symbol.

libtool: link: x86_64-pc-linux-gnu-gcc -D_GNU_SOURCE -Wno-pointer-sign -march=native -O2 -pipe -Wl,-O1 -Wl,--defsym=__gentoo_check_ldflags__=0 -o .libs/aureport aureport.o auditd-config.o ausearch-llist.o aureport-options.o ausearch-string.o ausearch-parse.o aureport-scan.o aureport-output.o ausearch-lookup.o ausearch-int.o ausearch-time.o ausearch-nvpair.o ausearch-avc.o ausearch-lol.o  -Wl,--as-needed -L../lib -L../auparse /var/tmp/portage-tmpfs/portage/sys-process/audit-2.8.5-r1/work/audit-userspace-80866dc78b5db17010516e24344eaed8dcc6fb99-abi_x86_64.amd64/auparse/.libs/libauparse.so /var/tmp/portage-tmpfs/portage/sys-process/audit-2.8.5-r1/work/audit-userspace-80866dc78b5db17010516e24344eaed8dcc6fb99-abi_x86_64.amd64/lib/.libs/libaudit.so -lcap-ng
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-llist.o:(.bss+0x0): multiple definition of `event_node_list'; ausearch.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-options.o:(.bss+0xc8): multiple definition of `event_node_list'; ausearch.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-report.o:(.bss+0x0): multiple definition of `event_node_list'; ausearch.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-match.o:(.bss+0x0): multiple definition of `event_node_list'; ausearch.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-parse.o:(.bss+0x0): multiple definition of `event_node_list'; ausearch.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-time.o:(.bss+0x10): multiple definition of `event_node_list'; ausearch.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-lookup.o:(.bss+0x0): multiple definition of `event_node_list'; ausearch.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-lol.o:(.bss+0x28): multiple definition of `event_node_list'; ausearch.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-checkpt.o:(.bss+0x40): multiple definition of `event_node_list'; ausearch.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-llist.o:(.bss+0x0): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: aureport-options.o:(.bss+0xa0): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-parse.o:(.bss+0x0): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: aureport-scan.o:(.bss+0x1f8): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: aureport-output.o:(.bss+0x8): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-lookup.o:(.bss+0x0): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-time.o:(.bss+0x10): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ausearch-lol.o:(.bss+0x28): multiple definition of `event_node_list'; aureport.o:(.bss+0x28): first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:589: ausearch] Error 1
make[3]: *** Waiting for unfinished jobs....
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:585: aureport] Error 1
make[3]: Leaving directory '/var/tmp/portage-tmpfs/portage/sys-process/audit-2.8.5-r1/work/audit-userspace-80866dc78b5db17010516e24344eaed8dcc6fb99-abi_x86_64.amd64/src'
make[2]: *** [Makefile:829: all-recursive] Error 1
make[2]: Leaving directory '/var/tmp/portage-tmpfs/portage/sys-process/audit-2.8.5-r1/work/audit-userspace-80866dc78b5db17010516e24344eaed8dcc6fb99-abi_x86_64.amd64/src'
make[1]: *** [Makefile:468: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage-tmpfs/portage/sys-process/audit-2.8.5-r1/work/audit-userspace-80866dc78b5db17010516e24344eaed8dcc6fb99-abi_x86_64.amd64'
make: *** [Makefile:400: all] Error 2
 * ERROR: sys-process/audit-2.8.5-r1::gentoo failed (compile phase):
 *   emake failed
Comment 12 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2020-06-10 22:34:16 UTC
Created attachment 644322 [details]
sys-process/audit/audit-2.8.5-r1.ebuild
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-11 07:26:24 UTC
(In reply to Robin Johnson from comment #12)
> Created attachment 644322 [details]
> sys-process/audit/audit-2.8.5-r1.ebuild

After src_prepare for both ebuilds, in the directory diff between the unpacked sources of audit-2.8.5.ebuild and the attached audit-2.8.5-r1.ebuild, I do not see the fix in src/ausearch-common.h at all. Did you pick the wrong head commit?
Comment 14 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-11 07:39:08 UTC
(In reply to Jeroen Roovers from comment #13)
> (In reply to Robin Johnson from comment #12)
> > Created attachment 644322 [details]
> > sys-process/audit/audit-2.8.5-r1.ebuild
> 
> After src_prepare for both ebuilds, in the directory diff between the
> unpacked sources of audit-2.8.5.ebuild and the attached
> audit-2.8.5-r1.ebuild, I do not see the fix in src/ausearch-common.h at all.
> Did you pick the wrong head commit?

I see what happened there. The commit you picked is in the 2.8_maintenance branch, whereas the commit matching the attached patch is only in the master branch and not back-ported to the 2.8_maintenance branch.
Comment 15 Larry the Git Cow gentoo-dev 2020-07-05 22:36:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=02b399622334871b168d21845e0ce30b33745b38

commit 02b399622334871b168d21845e0ce30b33745b38
Author:     Robin H. Johnson <robbat2@gentoo.org>
AuthorDate: 2020-07-05 22:36:04 +0000
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: 2020-07-05 22:36:43 +0000

    sys-process/audit: -fno-common fix
    
    Closes: https://bugs.gentoo.org/706734
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

 sys-process/audit/Manifest              |   2 +
 sys-process/audit/audit-2.8.5-r1.ebuild | 238 ++++++++++++++++++++++++++++++++
 2 files changed, 240 insertions(+)
Comment 16 Larry the Git Cow gentoo-dev 2021-01-04 11:11:48 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=852e1a4913c6d3ea5fec171de65944bdf3cce059

commit 852e1a4913c6d3ea5fec171de65944bdf3cce059
Author:     Andreas K. Huettel <dilfridge@gentoo.org>
AuthorDate: 2021-01-03 09:00:05 +0000
Commit:     Andreas K. Huettel <dilfridge@gentoo.org>
CommitDate: 2021-01-04 11:11:23 +0000

    sys-process/audit: Remove old
    
    Bug: https://bugs.gentoo.org/706734
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Andreas K. Huettel <dilfridge@gentoo.org>

 sys-process/audit/Manifest           |   2 -
 sys-process/audit/audit-2.8.4.ebuild | 206 -----------------------------------
 sys-process/audit/audit-2.8.5.ebuild | 204 ----------------------------------
 3 files changed, 412 deletions(-)