Created attachment 604120 [details, diff] patch net-misc/youtube-viewer-9999 no longer works due to upstream changes. I have refactored the ebuild to convert it from EAPI 6 to EAPI 7, removed dependency on legacy inherit gnome2-utils replaced with inherit desktop, and adjusted the USE flags to reflect upstream changes.
"Something does not work but I will not tell you what it is but here is a patch."
(In reply to Jeroen Roovers from comment #1) > "Something does not work but I will not tell you what it is but here is a > patch." what are you talking about? read comment zero.
Created attachment 610152 [details] complete ebuild here is the complete standalone ebuild
Created attachment 610154 [details] updated metadata file
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman * please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/) # Copyright 1999-2019 Gentoo Authors * A bot can look for additional mistakes, if you upload a PR via github * is eutils really needed here?
Created attachment 610714 [details] complete ebuild No, turns out eutils was no longer needed. thank you for pointing that out. also corrected copyright RepoMan sez: "If everyone were like you, I'd be out of business!"
regarding the XML change, there are some older release versions using the ambiguous 'gtk' flag rather than gtk2. If needed I could go back and update those ebuilds as well to switch them over to 'gtk2' otherwise I could add another metadata.xml that marks the old 'gtk' flag as deprecated. I am personally thinking just switching the older ebuilds use flag out is the cleaner option here, what do you think?
It seems I've never got around to port this ebuild to EAPI=7. Thanks Thomas for bringing it up and putting up a fix. Will you submit a PR on GitHub for it? As for the gtk flag on the other ebuilds. I'll fix them in testing. Let's leave the stable as is, as I'll get it replaced with a new stable soon after the GTK flag has been fixed.
(In reply to Jonas Stein from comment #5) > * is eutils really needed here? Yes, it's needed as "optfeature" used in pkg_postinst() comes from there.
I've submitted a PR for several youtube-viewer ebuild changes, including a polished up version of the 9999 ebuild as well (i.e. added gtk3 support, metadata XML changes), that Thomas has kindly provided. I hope that's okay.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d8e61d5d550a7c2b12477060b2acaa0ccd43133 commit 7d8e61d5d550a7c2b12477060b2acaa0ccd43133 Author: Zoltan Puskas <zoltan@sinustrom.info> AuthorDate: 2020-02-03 03:29:23 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-03-05 12:01:20 +0000 net-misc/youtube-viewer: Update 9999 to EAPI 7 and add gtk3 support Closes: https://bugs.gentoo.org/706222 Package-Manager: Portage-2.3.85, Repoman-2.3.20 Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info> Closes: https://github.com/gentoo/gentoo/pull/14536 Signed-off-by: Joonas Niilola <juippis@gentoo.org> net-misc/youtube-viewer/youtube-viewer-9999.ebuild | 39 ++++++++++++++++------ 1 file changed, 28 insertions(+), 11 deletions(-)
