Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705908 - [kde overlay] app-office/kmymoney: add use flag to allow UNFINISHEDFEATURES
Summary: [kde overlay] app-office/kmymoney: add use flag to allow UNFINISHEDFEATURES
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-20 00:08 UTC by Jack
Modified: 2020-01-26 22:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for kmymoney-5.0.9999.ebuild (KMM_addunfinished_50.patch,583 bytes, patch)
2020-01-20 00:08 UTC, Jack
Details | Diff
patch for kmymoney-9999.ebuild (KMM_addunfinished_master.patch,575 bytes, patch)
2020-01-20 00:09 UTC, Jack
Details | Diff
patch for metadata file (KMM_addunfinished_metadata.patch,569 bytes, patch)
2020-01-20 00:09 UTC, Jack
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2020-01-20 00:08:21 UTC
Created attachment 603780 [details, diff]
patch for kmymoney-5.0.9999.ebuild

There is a -DENABLE_UNFINISHEDFEATURES configuration option for KMyMoney which currently cannot be turned on with the existing ebuilds.  As it is most likely to be wanted by people using the git head versions, I am proposing the enhancement for both kmymoney-5.0.9999.ebuild and for kmymoney-9999.ebuild.

I've done this by adding an "advanced" useflag, and having this control the -DENABLE_UNFINISHEDFEATURES config option.

I've attached patches for the two ebuilds, and for the metadata file to add a description of the use flag.
Comment 1 Jack 2020-01-20 00:09:00 UTC
Created attachment 603782 [details, diff]
patch for kmymoney-9999.ebuild
Comment 2 Jack 2020-01-20 00:09:36 UTC
Created attachment 603784 [details, diff]
patch for metadata file
Comment 3 Andreas Sturmlechner gentoo-dev 2020-01-20 00:11:40 UTC
I don't think that `advanced` is a good name for that. How about `experimental`?
Comment 4 Andreas Sturmlechner gentoo-dev 2020-01-20 00:12:50 UTC
How likely is that flag to break the builds?
Comment 5 Jack 2020-01-20 00:22:39 UTC
I definitely like "experimental" better.
Using that setting should not break the build.  It might break the runtime, but that's largely what it's there for.  It might be nice to add some caveat or warning that it enables the inclusion of unfinished features, and should only be used for testing those features. (or something like that)

I recently used it per request of the developer, to troubleshoot a display problem under Wayland.  The newer version of the ledger did NOT display the problem, helping the developer focus on where the problem was - but the new ledger completely blew up with my personal data (which had a tendency to do that, so I wasn't all that surprised, and clearly not upset.)
Comment 6 Larry the Git Cow gentoo-dev 2020-01-26 21:16:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=8dbd512b9a701f3fdb2aae8cbee8b387a5f4d807

commit 8dbd512b9a701f3fdb2aae8cbee8b387a5f4d807
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-01-26 21:15:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-01-26 21:15:15 +0000

    app-office/kmymoney: Add USE experimental - only for live
    
    Closes: https://bugs.gentoo.org/705908
    Package-Manager: Portage-2.3.85, Repoman-2.3.20
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-office/kmymoney/kmymoney-5.0.9999.ebuild | 11 ++++++++++-
 app-office/kmymoney/kmymoney-9999.ebuild     | 11 ++++++++++-
 app-office/kmymoney/metadata.xml             |  1 +
 3 files changed, 21 insertions(+), 2 deletions(-)
Comment 7 Jack 2020-01-26 22:20:08 UTC
TYPO:  it's "unfinished features" not "infinished"

Pure curiosity - why the move of kdewebkit down one line?  How does the order matter?  (Pointer to the fine manual I should have read is fine.)

I also think the warning is just a bit extreme, but anyone doing this really should know what they are doing, so I suppose it makes sense.

Thanks for accepting the idea.
Comment 8 Andreas Sturmlechner gentoo-dev 2020-01-26 22:23:33 UTC
(In reply to Jack from comment #7)
> Pure curiosity - why the move of kdewebkit down one line?  How does the
> order matter?  (Pointer to the fine manual I should have read is fine.)
Alphanumerical sorting, readability.